From: Mark Brown <broonie@kernel.org>
To: Conor Dooley <conor.dooley@microchip.com>
Cc: linux-spi@vger.kernel.org, linux-fpga@vger.kernel.org,
conor@kernel.org, Vladimir Georgiev <v.georgiev@metrotek.ru>,
Moritz Fischer <mdf@kernel.org>, Wu Hao <hao.wu@intel.com>,
Xu Yilun <yilun.xu@intel.com>, Tom Rix <trix@redhat.com>,
valentina.fernandezalanis@microchip.com
Subject: Re: [BUG] microchip-spi programming issue
Date: Tue, 6 Jun 2023 12:55:58 +0100 [thread overview]
Message-ID: <e0b6908a-7f13-425d-8f5a-e9e90a54a2c1@sirena.org.uk> (raw)
In-Reply-To: <20230606-reentry-undusted-3c44fd7b4325@wendy>
[-- Attachment #1: Type: text/plain, Size: 504 bytes --]
On Tue, Jun 06, 2023 at 12:30:02PM +0100, Conor Dooley wrote:
> Following on from that, how strong is "normally" in the comment above?
> Is it valid for a controller to deassert CS even if cs_change is not
> set? Or have I totally misunderstood things and there's something
> invalid about how the transfers are being set up in the driver?
It is obviously going to corrupt the transfer if we deassert chip select
without being asked, it is only valid to change it during a message if
cs_change is set.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-06-06 11:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 11:30 [BUG] microchip-spi programming issue Conor Dooley
2023-06-06 11:55 ` Mark Brown [this message]
2023-06-06 12:01 ` Conor Dooley
2023-06-06 12:04 ` Mark Brown
2023-06-07 16:48 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0b6908a-7f13-425d-8f5a-e9e90a54a2c1@sirena.org.uk \
--to=broonie@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=hao.wu@intel.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=trix@redhat.com \
--cc=v.georgiev@metrotek.ru \
--cc=valentina.fernandezalanis@microchip.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).