* [PATCH 0/2] exfat: allow access to paths with trailing dots
@ 2021-08-18 11:11 David Disseldorp
2021-08-18 12:48 ` Christian Brauner
0 siblings, 1 reply; 5+ messages in thread
From: David Disseldorp @ 2021-08-18 11:11 UTC (permalink / raw
To: linux-fsdevel
This patchset adds a new exfat "keeptail" mount option, which allows
users to resolve paths carrying trailing period '.' characters.
I'm not a huge fan of "keeptail" as an option name, but couldn't think
of anything better.
Feedback appreciated.
Cheers, David
--
fs/exfat/exfat_fs.h | 3 ++-
fs/exfat/namei.c | 25 ++++++++++++++-----------
fs/exfat/super.c | 7 +++++++
3 files changed, 23 insertions(+), 12 deletions(-)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/2] exfat: allow access to paths with trailing dots
2021-08-18 11:11 David Disseldorp
@ 2021-08-18 12:48 ` Christian Brauner
2021-08-18 16:40 ` David Disseldorp
0 siblings, 1 reply; 5+ messages in thread
From: Christian Brauner @ 2021-08-18 12:48 UTC (permalink / raw
To: David Disseldorp; +Cc: linux-fsdevel
On Wed, Aug 18, 2021 at 01:11:21PM +0200, David Disseldorp wrote:
> This patchset adds a new exfat "keeptail" mount option, which allows
> users to resolve paths carrying trailing period '.' characters.
> I'm not a huge fan of "keeptail" as an option name, but couldn't think
> of anything better.
I wouldn't use "period". The vfs uses "dot" and "dotdot" as seen in e.g.
LAST_DOT or LAST_DOTOT. Maybe "keep_last_dot"?
Christian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/2] exfat: allow access to paths with trailing dots
2021-08-18 12:48 ` Christian Brauner
@ 2021-08-18 16:40 ` David Disseldorp
2021-08-18 17:49 ` Christian Brauner
0 siblings, 1 reply; 5+ messages in thread
From: David Disseldorp @ 2021-08-18 16:40 UTC (permalink / raw
To: Christian Brauner; +Cc: linux-fsdevel
On Wed, 18 Aug 2021 14:48:35 +0200, Christian Brauner wrote:
> On Wed, Aug 18, 2021 at 01:11:21PM +0200, David Disseldorp wrote:
> > This patchset adds a new exfat "keeptail" mount option, which allows
> > users to resolve paths carrying trailing period '.' characters.
> > I'm not a huge fan of "keeptail" as an option name, but couldn't think
> > of anything better.
>
> I wouldn't use "period". The vfs uses "dot" and "dotdot" as seen in e.g.
> LAST_DOT or LAST_DOTOT. Maybe "keep_last_dot"?
Works for me, although I was under the impression that underscores were
avoided for mount options. Also, I think it'd be clearer as the plural
"keep_last_dots".
Cheers, David
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/2] exfat: allow access to paths with trailing dots
2021-08-18 16:40 ` David Disseldorp
@ 2021-08-18 17:49 ` Christian Brauner
0 siblings, 0 replies; 5+ messages in thread
From: Christian Brauner @ 2021-08-18 17:49 UTC (permalink / raw
To: David Disseldorp; +Cc: linux-fsdevel
On Wed, Aug 18, 2021 at 06:40:16PM +0200, David Disseldorp wrote:
> On Wed, 18 Aug 2021 14:48:35 +0200, Christian Brauner wrote:
>
> > On Wed, Aug 18, 2021 at 01:11:21PM +0200, David Disseldorp wrote:
> > > This patchset adds a new exfat "keeptail" mount option, which allows
> > > users to resolve paths carrying trailing period '.' characters.
> > > I'm not a huge fan of "keeptail" as an option name, but couldn't think
> > > of anything better.
> >
> > I wouldn't use "period". The vfs uses "dot" and "dotdot" as seen in e.g.
> > LAST_DOT or LAST_DOTOT. Maybe "keep_last_dot"?
>
> Works for me, although I was under the impression that underscores were
> avoided for mount options. Also, I think it'd be clearer as the plural
Oh? I' just - for unrelated reasons - looking at cifs code and I
immediately see:
min_enc_offload
max_credits
_netdev
which doesn't necessarily mean that I'm right but rather that that ship
might have sailed. :)
Christian
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH 0/2] exfat: allow access to paths with trailing dots
[not found] ` <20210820151214.37742aad@suse.de>
@ 2021-08-23 4:48 ` Namjae Jeon
0 siblings, 0 replies; 5+ messages in thread
From: Namjae Jeon @ 2021-08-23 4:48 UTC (permalink / raw
To: 'David Disseldorp'
Cc: 'Sungjong Seo', 'Namjae Jeon', linux-fsdevel
> Date: Wed, 18 Aug 2021 13:11:21 +0200
> From: David Disseldorp <ddiss@suse.de>
> To: linux-fsdevel@vger.kernel.org
> Subject: [PATCH 0/2] exfat: allow access to paths with trailing dots
>
>
Hi David,
> This patchset adds a new exfat "keeptail" mount option, which allows users to resolve paths carrying
> trailing period '.' characters.
> I'm not a huge fan of "keeptail" as an option name, but couldn't think of anything better.
We are concerning that this mount option allow to create the filename that
contain trailing period. It will cause the compatibility issues with windows.
I think compatibility with windows is more important than fuse-exfat.
Can we only allow those files to be accessed and prevented from being created?
>
> Feedback appreciated.
Thanks!
>
> Cheers, David
>
> --
>
> fs/exfat/exfat_fs.h | 3 ++-
> fs/exfat/namei.c | 25 ++++++++++++++-----------
> fs/exfat/super.c | 7 +++++++
> 3 files changed, 23 insertions(+), 12 deletions(-)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-08-23 4:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20210820131220epcas1p1e97adf5dfc5125571733d42d5d71110c@epcas1p1.samsung.com>
[not found] ` <20210820151214.37742aad@suse.de>
2021-08-23 4:48 ` [PATCH 0/2] exfat: allow access to paths with trailing dots Namjae Jeon
2021-08-18 11:11 David Disseldorp
2021-08-18 12:48 ` Christian Brauner
2021-08-18 16:40 ` David Disseldorp
2021-08-18 17:49 ` Christian Brauner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).