From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
He Kuang <hekuang@huawei.com>
Subject: Re: Q. hlist_bl_add_head_rcu() in d_alloc_parallel()
Date: Wed, 29 Jun 2016 09:17:05 +0100 [thread overview]
Message-ID: <20160629081705.GZ14480@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CA+55aFyboLUOqNgDSF9_3iK9ECRFP821Bzmd88ABHj7xSGwWUw@mail.gmail.com>
On Sat, Jun 25, 2016 at 06:25:58PM -0700, Linus Torvalds wrote:
> On Sat, Jun 25, 2016 at 3:54 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> >
> > BTW, speaking of that area - is there any reason why dentry_cmp()
> > isn't simply
> > return dentry_string_cmp(lockless_dereference(dentry->d_name.name),
> > ct, tcount);
> > other than "it predates lockless_dereference()"?
>
> No, the only important thing is that it's a read-once, and has the
> smp_read_barrier_depends().
>
> So lockless_derefence() looks like the right thing to do, it is just
> that - as you suspected - the code predates that concept.
... and as the matter of fact, patch to that effect (only cosmetically different
from what I'd cooked) had been posted by He Kuang back in March. At least
I'd spotted that before pushing mine out...
The patch posted back then applied, with slightly edited commit message. Apologies
for missing it...
next prev parent reply other threads:[~2016-06-29 8:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 20:50 Q. hlist_bl_add_head_rcu() in d_alloc_parallel() J. R. Okajima
2016-06-17 22:16 ` Al Viro
2016-06-17 22:56 ` Al Viro
2016-06-19 5:24 ` J. R. Okajima
2016-06-19 16:55 ` Al Viro
2016-06-20 4:34 ` J. R. Okajima
2016-06-20 5:35 ` Al Viro
2016-06-20 14:51 ` Al Viro
2016-06-20 17:14 ` [git pull] vfs fixes Al Viro
2016-06-23 1:19 ` Q. hlist_bl_add_head_rcu() in d_alloc_parallel() J. R. Okajima
2016-06-23 2:58 ` Al Viro
2016-06-24 5:57 ` Linus Torvalds
2016-06-25 22:54 ` Al Viro
2016-06-26 1:25 ` Linus Torvalds
2016-06-29 8:17 ` Al Viro [this message]
2016-06-29 9:22 ` Hekuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160629081705.GZ14480@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=hekuang@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).