From: Andreas Gruenbacher <agruenba@redhat.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, gfs2@lists.linux.dev
Subject: Re: [PATCH 2/4] gfs2: Add a migrate_folio operation for journalled files
Date: Fri, 3 May 2024 21:04:15 +0200 [thread overview]
Message-ID: <CAHc6FU4c6+Bz+1fzj-anNGm8TQhvLSGHMnd37S58kG_FeM88rw@mail.gmail.com> (raw)
In-Reply-To: <ZjUtSAxhcMnQ71fO@casper.infradead.org>
On Fri, May 3, 2024 at 8:30 PM Matthew Wilcox <willy@infradead.org> wrote:
> On Thu, May 02, 2024 at 10:23:41PM +0200, Andreas Gruenbacher wrote:
> > On Wed, Apr 3, 2024 at 7:24 PM Matthew Wilcox (Oracle)
> > <willy@infradead.org> wrote:
> > > For journalled data, folio migration currently works by writing the folio
> > > back, freeing the folio and faulting the new folio back in. We can
> > > bypass that by telling the migration code to migrate the buffer_heads
> > > attached to our folios.
> >
> > This part sounds reasonable, but I disagree with the following assertion:
> >
> > > That lets us delete gfs2_jdata_writepage() as it has no more callers.
> >
> > The reason is that the log flush code calls gfs2_jdata_writepage()
> > indirectly via mapping->a_ops->writepage. So with this patch, we end
> > up with a bunch of Oopses.
> >
> > Do you want to resend, or should I back out the gfs2_jdata_writepage
> > removal and add the remaining one-liner?
>
> Ugh, I see. If you could just add the one-liner for now, and I'll
> come back with a better proposal next for merge window?
Sure, pushed to for-next.
Thanks again,
Andreas
next prev parent reply other threads:[~2024-05-03 19:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 17:23 [PATCH 0/4] More GFS2 folio conversions Matthew Wilcox (Oracle)
2024-04-03 17:23 ` [PATCH 1/4] gfs2: Convert gfs2_page_mkwrite() to use a folio Matthew Wilcox (Oracle)
2024-04-03 17:23 ` [PATCH 2/4] gfs2: Add a migrate_folio operation for journalled files Matthew Wilcox (Oracle)
2024-05-02 20:23 ` Andreas Gruenbacher
2024-05-03 18:30 ` Matthew Wilcox
2024-05-03 19:04 ` Andreas Gruenbacher [this message]
2024-04-03 17:23 ` [PATCH 3/4] gfs2: Simplify gfs2_read_super Matthew Wilcox (Oracle)
2024-04-03 17:23 ` [PATCH 4/4] gfs2: Convert gfs2_aspace_writepage() to use a folio Matthew Wilcox (Oracle)
2024-05-02 20:17 ` [PATCH 0/4] More GFS2 folio conversions Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHc6FU4c6+Bz+1fzj-anNGm8TQhvLSGHMnd37S58kG_FeM88rw@mail.gmail.com \
--to=agruenba@redhat.com \
--cc=gfs2@lists.linux.dev \
--cc=linux-fsdevel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).