From: Muchun Song <songmuchun@bytedance.com>
To: Michal Hocko <mhocko@suse.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Tejun Heo <tj@kernel.org>,
axboe@fb.com, Matthew Wilcox <willy@infradead.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [External] Re: [PATCH v2] writeback: fix obtain a reference to a freeing memcg css
Date: Thu, 1 Apr 2021 21:59:13 +0800 [thread overview]
Message-ID: <CAMZfGtX9V898aezb-huMEYU_-NjqfL6HbXeaZr2Q2MUa+VG3qQ@mail.gmail.com> (raw)
In-Reply-To: <YGWf1C/gIZgs0AhR@dhcp22.suse.cz>
On Thu, Apr 1, 2021 at 6:26 PM Michal Hocko <mhocko@suse.com> wrote:
>
> On Thu 01-04-21 17:33:43, Muchun Song wrote:
> > The caller of wb_get_create() should pin the memcg, because
> > wb_get_create() relies on this guarantee. The rcu read lock
> > only can guarantee that the memcg css returned by css_from_id()
> > cannot be released, but the reference of the memcg can be zero.
> > Fix it by holding a reference to the css before calling
> > wb_get_create(). This is not a problem I encountered in the
> > real world. Just the result of a code review.
> >
> > And it is unnecessary to use GFP_ATOMIC, so replace it with
> > GFP_NOIO.
>
> This should go into it's own patch. With more explanation why NOIO is
> required.
OK. Replacing GFP_ATOMIC with NOIO should be a separate
patch. I will remove this in the next version.
>
> > Fixes: 682aa8e1a6a1 ("writeback: implement unlocked_inode_to_wb transaction and use it for stat updates")
> > Signed-off-by: Muchun Song <songmuchun@bytedance.com>
>
> For the css part feel free to add
> Acked-by: Michal Hocko <mhocko@suse.com>
Thanks.
>
> Even if the css ref count is not really necessary it shouldn't cause any
> harm and it makes the code easier to understand. At least a comment
> explaining why that is not necessary would be required without it
OK. I will add a comment here to explain why we need to hold a
ref.
>
> Thanks!
>
> > ---
> > Changelog in v2:
> > 1. Replace GFP_ATOMIC with GFP_NOIO suggested by Matthew.
> >
> > fs/fs-writeback.c | 11 ++++++++---
> > 1 file changed, 8 insertions(+), 3 deletions(-)
> >
> > diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> > index e91980f49388..df7f89f8f771 100644
> > --- a/fs/fs-writeback.c
> > +++ b/fs/fs-writeback.c
> > @@ -501,16 +501,21 @@ static void inode_switch_wbs(struct inode *inode, int new_wb_id)
> > if (atomic_read(&isw_nr_in_flight) > WB_FRN_MAX_IN_FLIGHT)
> > return;
> >
> > - isw = kzalloc(sizeof(*isw), GFP_ATOMIC);
> > + isw = kzalloc(sizeof(*isw), GFP_NOIO);
> > if (!isw)
> > return;
> >
> > /* find and pin the new wb */
> > rcu_read_lock();
> > memcg_css = css_from_id(new_wb_id, &memory_cgrp_subsys);
> > - if (memcg_css)
> > - isw->new_wb = wb_get_create(bdi, memcg_css, GFP_ATOMIC);
> > + if (memcg_css && !css_tryget(memcg_css))
> > + memcg_css = NULL;
> > rcu_read_unlock();
> > + if (!memcg_css)
> > + goto out_free;
> > +
> > + isw->new_wb = wb_get_create(bdi, memcg_css, GFP_NOIO);
> > + css_put(memcg_css);
> > if (!isw->new_wb)
> > goto out_free;
> >
> > --
> > 2.11.0
>
> --
> Michal Hocko
> SUSE Labs
next prev parent reply other threads:[~2021-04-01 17:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 9:33 [PATCH v2] writeback: fix obtain a reference to a freeing memcg css Muchun Song
2021-04-01 10:26 ` Michal Hocko
2021-04-01 13:59 ` Muchun Song [this message]
2021-04-01 14:37 ` [External] " Michal Hocko
2021-04-01 14:39 ` Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMZfGtX9V898aezb-huMEYU_-NjqfL6HbXeaZr2Q2MUa+VG3qQ@mail.gmail.com \
--to=songmuchun@bytedance.com \
--cc=axboe@fb.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).