From: Baokun Li <libaokun@huaweicloud.com>
To: netfs@lists.linux.dev, dhowells@redhat.com, jlayton@kernel.org
Cc: linux-cachefs@redhat.com, linux-erofs@lists.ozlabs.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
yangerkun <yangerkun@huawei.com>,
libaokun@huaweicloud.com
Subject: Re: [PATCH 0/5] cachefiles: some bugfixes for withdraw and xattr
Date: Tue, 7 May 2024 19:20:08 +0800 [thread overview]
Message-ID: <a6d89482-6f81-29d1-3e9f-4772ffbb56af@huaweicloud.com> (raw)
In-Reply-To: <20240424032732.2711487-1-libaokun@huaweicloud.com>
Hi David,
Hi Jeff,
Could you please take time to take a look at this series? I'd
appreciated it
if I could get some feedback and comments.
Thanks,
Baokun
On 2024/4/24 11:27, libaokun@huaweicloud.com wrote:
> From: Baokun Li <libaokun1@huawei.com>
>
> Hello everyone!
>
> Recently we found some bugs while doing tests on cachefiles ondemand mode,
> and this patchset is a fix for some of those issues. The following is a
> brief overview of the patches, see the patches for more details.
>
> Patch 1-2: Add fscache_try_get_volume() helper function to avoid
> fscache_volume use-after-free on cache withdrawal.
>
> Patch 3: Fix cachefiles_lookup_cookie() and cachefiles_withdraw_cache()
> concurrency causing cachefiles_volume use-after-free.
>
> Patch 4-5: Propagate error codes returned by vfs_getxattr() to avoid
> endless loops.
>
> Comments and questions are, as always, welcome.
>
> Thanks,
> Baokun
>
> Baokun Li (5):
> netfs, fscache: export fscache_put_volume() and add
> fscache_try_get_volume()
> cachefiles: fix slab-use-after-free in fscache_withdraw_volume()
> cachefiles: fix slab-use-after-free in cachefiles_withdraw_cookie()
> cachefiles: correct the return value of
> cachefiles_check_volume_xattr()
> cachefiles: correct the return value of cachefiles_check_auxdata()
>
> fs/cachefiles/cache.c | 45 +++++++++++++++++++++++++++++++++-
> fs/cachefiles/volume.c | 1 -
> fs/cachefiles/xattr.c | 5 +++-
> fs/netfs/fscache_volume.c | 14 +++++++++++
> fs/netfs/internal.h | 2 --
> include/linux/fscache-cache.h | 6 +++++
> include/trace/events/fscache.h | 4 +++
> 7 files changed, 72 insertions(+), 5 deletions(-)
>
prev parent reply other threads:[~2024-05-07 11:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 3:27 [PATCH 0/5] cachefiles: some bugfixes for withdraw and xattr libaokun
2024-04-24 3:27 ` [PATCH 1/5] netfs, fscache: export fscache_put_volume() and add fscache_try_get_volume() libaokun
2024-04-24 3:27 ` [PATCH 2/5] cachefiles: fix slab-use-after-free in fscache_withdraw_volume() libaokun
2024-04-24 3:27 ` [PATCH 3/5] cachefiles: fix slab-use-after-free in cachefiles_withdraw_cookie() libaokun
2024-04-24 3:27 ` [PATCH 4/5] cachefiles: correct the return value of cachefiles_check_volume_xattr() libaokun
2024-04-24 3:27 ` [PATCH 5/5] cachefiles: correct the return value of cachefiles_check_auxdata() libaokun
2024-05-07 11:20 ` Baokun Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6d89482-6f81-29d1-3e9f-4772ffbb56af@huaweicloud.com \
--to=libaokun@huaweicloud.com \
--cc=dhowells@redhat.com \
--cc=jlayton@kernel.org \
--cc=linux-cachefs@redhat.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netfs@lists.linux.dev \
--cc=yangerkun@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).