From: Bhargav Raviprakash <bhargav.r@ltts.com>
To: eblanc@baylibre.com
Cc: arnd@arndb.de, bhargav.r@ltts.com, broonie@kernel.org,
conor+dt@kernel.org, devicetree@vger.kernel.org,
gregkh@linuxfoundation.org, jpanis@baylibre.com,
kristo@kernel.org, krzysztof.kozlowski+dt@linaro.org,
lee@kernel.org, lgirdwood@gmail.com, linus.walleij@linaro.org,
linux-arm-kernel@lists.infradead.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
m.nirmaladevi@ltts.com, nm@ti.com, robh+dt@kernel.org,
vigneshr@ti.com
Subject: Re: [PATCH v6 10/11] pinctrl: pinctrl-tps6594: Add TPS65224 PMIC pinctrl and GPIO
Date: Wed, 17 Apr 2024 10:39:19 +0000 [thread overview]
Message-ID: <0109018eeba3b870-adff6d96-6d05-45e3-b2ef-1b5ec0b034e0-000000@ap-south-1.amazonses.com> (raw)
In-Reply-To: <D0I0M4T4O9G1.UUESU247CE42@baylibre.com>
On Fri, 12 Apr 2024 10:52:43 +0200, Esteban Blanc wrote:
> On Mon Apr 8, 2024 at 2:40 PM CEST, Bhargav Raviprakash wrote:
> > From: Nirmala Devi Mal Nadar <m.nirmaladevi@ltts.com>
> >
> > Add support for TPS65224 pinctrl and GPIOs to TPS6594 driver as they have
> > significant functional overlap.
> > TPS65224 PMIC has 6 GPIOS which can be configured as GPIO or other
> > dedicated device functions.
> >
> > Signed-off-by: Nirmala Devi Mal Nadar <m.nirmaladevi@ltts.com>
> > Signed-off-by: Bhargav Raviprakash <bhargav.r@ltts.com>
> > Acked-by: Linus Walleij <linus.walleij@linaro.org>
> > ---
> > drivers/pinctrl/pinctrl-tps6594.c | 275 +++++++++++++++++++++++++-----
> > 1 file changed, 228 insertions(+), 47 deletions(-)
> >
> > diff --git a/drivers/pinctrl/pinctrl-tps6594.c b/drivers/pinctrl/pinctrl-tps6594.c
> > index 66985e54b..f3d1c1518 100644
> > --- a/drivers/pinctrl/pinctrl-tps6594.c
> > +++ b/drivers/pinctrl/pinctrl-tps6594.c
> > @@ -338,8 +506,20 @@ static int tps6594_pinctrl_probe(struct platform_device *pdev)
> > config.parent = tps->dev;
> > config.regmap = tps->regmap;
> > - config.ngpio = TPS6594_PINCTRL_PINS_NB;
> > - config.ngpio_per_reg = 8;
> > + switch (tps->chip_id) {
> > + case TPS65224:
> > + config.ngpio = ARRAY_SIZE(tps65224_gpio_func_group_names);
> > + config.ngpio_per_reg = TPS65224_NGPIO_PER_REG;
> > + break;
> > + case TPS6593:
> > + case TPS6594:
> > + config.ngpio = ARRAY_SIZE(tps6594_gpio_func_group_names);
> > + config.ngpio_per_reg = TPS6594_NGPIO_PER_REG;
> > + break;
> > + default:
> > + break;
> > + }
>
> Please merge the two switch case.
>
> Other than that I think it's ok.
>
> Best regards,
>
> --
> Esteban "Skallwar" Blanc
> BayLibre
Thanks! I will merge those switch cases in the next version.
Regards,
Bhargav
next prev parent reply other threads:[~2024-04-17 10:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 12:40 [PATCH v6 00/11] Add support for TI TPS65224 PMIC Bhargav Raviprakash
2024-04-08 12:40 ` [PATCH v6 01/11] mfd: tps6594: Add register definitions " Bhargav Raviprakash
2024-04-08 12:40 ` [PATCH v6 02/11] mfd: tps6594: use volatile_table instead of volatile_reg Bhargav Raviprakash
2024-04-08 12:40 ` [PATCH v6 03/11] mfd: tps6594: add regmap config in match data Bhargav Raviprakash
2024-04-11 17:03 ` Lee Jones
2024-04-15 13:10 ` [RESEND PATCH v1 05/13] mfd: tps6594-spi: Add TI TPS65224 PMIC SPI Bhargav Raviprakash
2024-04-16 12:25 ` Lee Jones
2024-04-17 10:35 ` [PATCH v6 03/11] mfd: tps6594: add regmap config in match data Bhargav Raviprakash
2024-04-08 12:40 ` [PATCH v6 04/11] dt-bindings: mfd: ti,tps6594: Add TI TPS65224 PMIC Bhargav Raviprakash
2024-04-08 12:40 ` [PATCH v6 05/11] mfd: tps6594-i2c: Add TI TPS65224 PMIC I2C Bhargav Raviprakash
2024-04-08 12:40 ` [PATCH v6 06/11] mfd: tps6594-spi: Add TI TPS65224 PMIC SPI Bhargav Raviprakash
2024-04-08 12:40 ` [PATCH v6 07/11] mfd: tps6594-core: Add TI TPS65224 PMIC core Bhargav Raviprakash
2024-04-08 12:40 ` [PATCH v6 08/11] misc: tps6594-pfsm: Add TI TPS65224 PMIC PFSM Bhargav Raviprakash
2024-04-11 13:03 ` Greg KH
2024-04-08 12:40 ` [PATCH v6 09/11] regulator: tps6594-regulator: Add TI TPS65224 PMIC regulators Bhargav Raviprakash
2024-04-08 12:40 ` [PATCH v6 10/11] pinctrl: pinctrl-tps6594: Add TPS65224 PMIC pinctrl and GPIO Bhargav Raviprakash
2024-04-12 8:52 ` Esteban Blanc
2024-04-17 10:39 ` Bhargav Raviprakash [this message]
2024-04-08 12:40 ` [PATCH v6 11/11] arch: arm64: dts: ti: k3-am62p5-sk: Add TPS65224 PMIC support in AM62P dts Bhargav Raviprakash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0109018eeba3b870-adff6d96-6d05-45e3-b2ef-1b5ec0b034e0-000000@ap-south-1.amazonses.com \
--to=bhargav.r@ltts.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eblanc@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jpanis@baylibre.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.nirmaladevi@ltts.com \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).