From: Bartosz Golaszewski <brgl@bgdev.pl>
To: "Linus Walleij" <linus.walleij@linaro.org>,
"Kent Gibson" <warthog618@gmail.com>,
"Gunnar Thörnqvist" <gunnar@igl.se>
Cc: linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: [libgpiod][PATCH v3 4/4] tools: add minutes as a new supported time unit
Date: Tue, 23 Apr 2024 12:04:52 +0200 [thread overview]
Message-ID: <20240423100452.32958-5-brgl@bgdev.pl> (raw)
In-Reply-To: <20240423100452.32958-1-brgl@bgdev.pl>
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Make it more convenient to specify longer time periods in gpio-tools by
introducing minutes as the new time unit.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
tools/tools-common.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/tools/tools-common.c b/tools/tools-common.c
index 500e9a2..4340bce 100644
--- a/tools/tools-common.c
+++ b/tools/tools-common.c
@@ -138,10 +138,12 @@ long long parse_period(const char *option)
}
if (m) {
- if (*end != 's')
+ if (*end == '\0')
+ m = 60000000;
+ else if (*end == 's')
+ end++;
+ else
return -1;
-
- end++;
} else {
m = 1000;
}
@@ -213,7 +215,7 @@ void print_period_help(void)
{
printf("\nPeriods:\n");
printf(" Periods are taken as milliseconds unless units are specified. e.g. 10us.\n");
- printf(" Supported units are 's', 'ms', and 'us'.\n");
+ printf(" Supported units are 'm', 's', 'ms', and 'us' for minutes, seconds, milliseconds and microseconds respectively.\n");
}
#define TIME_BUFFER_SIZE 20
--
2.40.1
next prev parent reply other threads:[~2024-04-23 10:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 10:04 [libgpiod][PATCH v3 0/4] tools: timeout handling improvements Bartosz Golaszewski
2024-04-23 10:04 ` [libgpiod][PATCH v3 1/4] tools: rename timeout to idle_timeout in gpiomon and gpionotify Bartosz Golaszewski
2024-04-23 10:04 ` [libgpiod][PATCH v3 2/4] tools: use ppoll() where higher timeout resolution makes sense Bartosz Golaszewski
2024-04-23 10:04 ` [libgpiod][PATCH v3 3/4] tools: allow longer time periods Bartosz Golaszewski
2024-04-23 10:04 ` Bartosz Golaszewski [this message]
2024-04-24 8:06 ` [libgpiod][PATCH v3 0/4] tools: timeout handling improvements Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240423100452.32958-5-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=bartosz.golaszewski@linaro.org \
--cc=gunnar@igl.se \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).