From: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
To: Lee Jones <lee@kernel.org>, Linus Walleij <linusw@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Bartosz Golaszewski <brgl@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Subject: [PATCH v3 1/4] mfd: timberdale: move GPIO_NR_PINS into the driver
Date: Fri, 27 Mar 2026 11:49:07 +0100 [thread overview]
Message-ID: <20260327-gpio-timberdale-swnode-v3-1-9a1bc1b2b124@oss.qualcomm.com> (raw)
In-Reply-To: <20260327-gpio-timberdale-swnode-v3-0-9a1bc1b2b124@oss.qualcomm.com>
This symbol is only used inside the timberdale MFD driver. Move into
the .c file as there's no need for it to be exposed in a header.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
drivers/mfd/timberdale.c | 2 ++
drivers/mfd/timberdale.h | 1 -
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/timberdale.c b/drivers/mfd/timberdale.c
index a4d9c070d481a182890a58e4b8c850c4c29f7f17..d79419215cc292b705031a6432e877b94f9a1805 100644
--- a/drivers/mfd/timberdale.c
+++ b/drivers/mfd/timberdale.c
@@ -37,6 +37,8 @@
#define DRIVER_NAME "timberdale"
+#define GPIO_NR_PINS 16
+
struct timberdale_device {
resource_size_t ctl_mapbase;
unsigned char __iomem *ctl_membase;
diff --git a/drivers/mfd/timberdale.h b/drivers/mfd/timberdale.h
index b01d2388e1afe59e14f77e10678bdbe599d2b90f..db7b434f766d03deb7c45ec1c8c5ded003aad087 100644
--- a/drivers/mfd/timberdale.h
+++ b/drivers/mfd/timberdale.h
@@ -113,7 +113,6 @@
#define GPIO_PIN_ASCB 8
#define GPIO_PIN_INIC_RST 14
#define GPIO_PIN_BT_RST 15
-#define GPIO_NR_PINS 16
/* DMA Channels */
#define DMA_UART_RX 0
--
2.47.3
next prev parent reply other threads:[~2026-03-27 10:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 10:49 [PATCH v3 0/4] gpio: timberdale: remove platform data header Bartosz Golaszewski
2026-03-27 10:49 ` Bartosz Golaszewski [this message]
2026-03-27 11:02 ` [PATCH v3 1/4] mfd: timberdale: move GPIO_NR_PINS into the driver Andy Shevchenko
2026-04-09 12:51 ` Lee Jones
2026-04-09 13:18 ` (subset) " Lee Jones
2026-04-09 13:20 ` Lee Jones
2026-04-09 13:21 ` Bartosz Golaszewski
2026-04-09 13:45 ` Lee Jones
2026-03-27 10:49 ` [PATCH v3 2/4] mfd: timberdale: set up a software node for the GPIO cell Bartosz Golaszewski
2026-04-30 9:48 ` (subset) " Lee Jones
2026-04-30 9:53 ` Lee Jones
2026-03-27 10:49 ` [PATCH v3 3/4] gpio: timberdale: use device properties Bartosz Golaszewski
2026-03-27 10:49 ` [PATCH v3 4/4] gpio: timberdale: remove platform data header Bartosz Golaszewski
2026-04-09 13:21 ` [PATCH v3 0/4] " Lee Jones
2026-04-30 9:48 ` Lee Jones
2026-04-30 9:52 ` Lee Jones
2026-05-11 7:34 ` Bartosz Golaszewski
2026-05-13 13:39 ` Lee Jones
2026-05-13 13:44 ` Bartosz Golaszewski
2026-05-07 15:28 ` [GIT PULL] Immutable branch between MFD and GPIO due for the v7.2 merge window Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260327-gpio-timberdale-swnode-v3-1-9a1bc1b2b124@oss.qualcomm.com \
--to=bartosz.golaszewski@oss.qualcomm.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brgl@kernel.org \
--cc=lee@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).