From: Linus Walleij <linusw@kernel.org>
To: Bjorn Andersson <andersson@kernel.org>,
Richard Acayan <mailingradian@gmail.com>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
kernel test robot <lkp@intel.com>,
Linus Walleij <linusw@kernel.org>
Subject: [PATCH] pinctrl: qcom: sdm670: Staticize groups and functions
Date: Thu, 09 Apr 2026 09:19:32 +0200 [thread overview]
Message-ID: <20260409-fix-sdm670-v1-1-8fe04a34968a@kernel.org> (raw)
The kernel test robot complains about undeclared local functions.
Fix it up.
Fixes: 9826035a75da ("pinctrl: qcom: add sdm670 lpi tlmm")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202604080950.Mvm8aN0a-lkp@intel.com/
Signed-off-by: Linus Walleij <linusw@kernel.org>
---
drivers/pinctrl/qcom/pinctrl-sdm670-lpass-lpi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-sdm670-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-sdm670-lpass-lpi.c
index 6270c6d09c22..858146c408d0 100644
--- a/drivers/pinctrl/qcom/pinctrl-sdm670-lpass-lpi.c
+++ b/drivers/pinctrl/qcom/pinctrl-sdm670-lpass-lpi.c
@@ -80,7 +80,7 @@ static const char * const pdm_sync_groups[] = { "gpio19" };
static const char * const pdm_tx_groups[] = { "gpio20" };
static const char * const slimbus_clk_groups[] = { "gpio18" };
-const struct lpi_pingroup sdm670_lpi_pinctrl_groups[] = {
+static const struct lpi_pingroup sdm670_lpi_pinctrl_groups[] = {
LPI_PINGROUP(0, LPI_NO_SLEW, _, _, _, _),
LPI_PINGROUP(1, LPI_NO_SLEW, _, _, _, _),
LPI_PINGROUP(2, LPI_NO_SLEW, _, _, _, _),
@@ -115,7 +115,7 @@ const struct lpi_pingroup sdm670_lpi_pinctrl_groups[] = {
LPI_PINGROUP(31, LPI_NO_SLEW, _, _, _, _),
};
-const struct lpi_function sdm670_lpi_pinctrl_functions[] = {
+static const struct lpi_function sdm670_lpi_pinctrl_functions[] = {
LPI_FUNCTION(comp_rx),
LPI_FUNCTION(dmic1_clk),
LPI_FUNCTION(dmic1_data),
---
base-commit: 7648112358a4207916d3e38bfee49f85552fe95f
change-id: 20260409-fix-sdm670-f1c6549c15c7
Best regards,
--
Linus Walleij <linusw@kernel.org>
reply other threads:[~2026-04-09 7:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260409-fix-sdm670-v1-1-8fe04a34968a@kernel.org \
--to=linusw@kernel.org \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mailingradian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).