From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Ma Ke <make_ruc2021@163.com>,
marcan@marcan.st, sven@svenpeter.dev, alyssa@rosenzweig.io,
linus.walleij@linaro.org
Cc: asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: apple-gpio: Fix null pointer dereference in apple_gpio_pinctrl_probe()
Date: Tue, 9 Apr 2024 13:53:02 +0200 [thread overview]
Message-ID: <30318fcc-5d6b-427b-855d-f69bcc165a54@linaro.org> (raw)
In-Reply-To: <20240409110254.2201457-1-make_ruc2021@163.com>
On 09/04/2024 13:02, Ma Ke wrote:
> devm_kasprintf() returns a pointer to dynamically allocated memory which
> can be NULL upon failure. We add a check to ensure that failure does not
> occur.
>
Subject: I doubt that there is null pointer dereference... Don't just
copy existing commit msgs or subjects without adjusting to real case.
> Signed-off-by: Ma Ke <make_ruc2021@163.com>
> ---
> drivers/pinctrl/pinctrl-apple-gpio.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pinctrl/pinctrl-apple-gpio.c b/drivers/pinctrl/pinctrl-apple-gpio.c
> index 3751c7de37aa..af2f90d1950f 100644
> --- a/drivers/pinctrl/pinctrl-apple-gpio.c
> +++ b/drivers/pinctrl/pinctrl-apple-gpio.c
> @@ -474,6 +474,8 @@ static int apple_gpio_pinctrl_probe(struct platform_device *pdev)
> for (i = 0; i < npins; i++) {
> pins[i].number = i;
> pins[i].name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "PIN%u", i);
> + if (!pins[i].name)
> + return -ENOMEM;
> pins[i].drv_data = pctl;
The check is a bit later, so please be more precise how do you fix it
and how did you reproduced it.
Maybe checking earlier is reasonable, maybe is redundant. You did not
address it...
Best regards,
Krzysztof
prev parent reply other threads:[~2024-04-09 11:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 11:02 [PATCH] pinctrl: apple-gpio: Fix null pointer dereference in apple_gpio_pinctrl_probe() Ma Ke
2024-04-09 11:53 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30318fcc-5d6b-427b-855d-f69bcc165a54@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=make_ruc2021@163.com \
--cc=marcan@marcan.st \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).