From: Zeng Heng <zengheng4@huawei.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: <linus.walleij@linaro.org>, <dan.carpenter@linaro.org>,
<linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<liwei391@huawei.com>
Subject: Re: [PATCH v2] pinctrl: devicetree: fix refcount leak in pinctrl_dt_to_map()
Date: Thu, 18 Apr 2024 19:54:10 +0800 [thread overview]
Message-ID: <442a67cb-8f1c-f6ac-98c1-ef97db52d5a2@huawei.com> (raw)
In-Reply-To: <ZiEGzuVzV_fV52DR@smile.fi.intel.com>
在 2024/4/18 19:41, Andy Shevchenko 写道:
> On Thu, Apr 18, 2024 at 07:34:59PM +0800, Zeng Heng wrote:
>> If we fail to allocate propname buffer, we need to drop the reference
>> count we just took, otherwise it will lead reference leak. Here the
>> error exit path is modified to jump to the err label and call
>> pinctrl_dt_free_maps() which would drop the counter.
>>
>> In the meantime, if it is found that the property 'pinctrl-0' is not
>> present, ENODEV is returned and also jump to the err label and call the
>> free function, in case the Smatch tool complains.
>> ---
> You forgot a changelog, but I think this needs to be a followup.
Oops, the resend patch would come soon.
Thanks,
Zeng Heng
prev parent reply other threads:[~2024-04-18 11:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 11:34 [PATCH v2] pinctrl: devicetree: fix refcount leak in pinctrl_dt_to_map() Zeng Heng
2024-04-18 11:41 ` Andy Shevchenko
2024-04-18 11:54 ` Zeng Heng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=442a67cb-8f1c-f6ac-98c1-ef97db52d5a2@huawei.com \
--to=zengheng4@huawei.com \
--cc=andriy.shevchenko@intel.com \
--cc=dan.carpenter@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liwei391@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).