From: Dan Scally <dan.scally@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>, linux-media@vger.kernel.org
Cc: Antti Laakso <antti.laakso@linux.intel.com>,
linux-gpio@vger.kernel.org, platform-driver-x86@vger.kernel.org,
linusw@kernel.org, brgl@kernel.org, mchehab@kernel.org,
ilpo.jarvinen@linux.intel.com, hverkuil+cisco@kernel.org,
sre@kernel.org, hao.yao@intel.com, jimmy.su@intel.com,
miguel.vadillo@intel.com, kees@kernel.org, ribalda@chromium.org
Subject: Re: [PATCH 1/1] platform: int3472: Drop redundant initialisation to 0 and NULL
Date: Fri, 27 Mar 2026 14:50:27 +0000 [thread overview]
Message-ID: <732143c6-3cca-4b47-8e7f-7f8d1499d901@ideasonboard.com> (raw)
In-Reply-To: <20260317131040.215119-1-sakari.ailus@linux.intel.com>
Hi Sakari
On 17/03/2026 13:10, Sakari Ailus wrote:
> A few fields in structs containing regulator initialisation data for Dell
> laptops are initialised to 0 and NULL. Drop the explicit initialisation as
> redundant.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
> drivers/platform/x86/intel/int3472/tps68470_board_data.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/platform/x86/intel/int3472/tps68470_board_data.c b/drivers/platform/x86/intel/int3472/tps68470_board_data.c
> index 6bec5a910396..c1ddbf9a82c0 100644
> --- a/drivers/platform/x86/intel/int3472/tps68470_board_data.c
> +++ b/drivers/platform/x86/intel/int3472/tps68470_board_data.c
> @@ -151,8 +151,6 @@ static const struct regulator_init_data dell_7212_tps68470_core_reg_init_data =
> .apply_uV = 1,
> .valid_ops_mask = REGULATOR_CHANGE_STATUS,
> },
> - .num_consumer_supplies = 0,
> - .consumer_supplies = NULL,
> };
>
> static const struct regulator_init_data dell_7212_tps68470_ana_reg_init_data = {
> @@ -162,8 +160,6 @@ static const struct regulator_init_data dell_7212_tps68470_ana_reg_init_data = {
> .apply_uV = 1,
> .valid_ops_mask = REGULATOR_CHANGE_STATUS,
> },
> - .num_consumer_supplies = 0,
> - .consumer_supplies = NULL,
> };
>
> static const struct regulator_init_data dell_7212_tps68470_vcm_reg_init_data = {
> @@ -173,8 +169,6 @@ static const struct regulator_init_data dell_7212_tps68470_vcm_reg_init_data = {
> .apply_uV = 1,
> .valid_ops_mask = REGULATOR_CHANGE_STATUS,
> },
> - .num_consumer_supplies = 0,
> - .consumer_supplies = NULL,
> };
>
> static const struct regulator_init_data dell_7212_tps68470_vio_reg_init_data = {
> @@ -184,8 +178,6 @@ static const struct regulator_init_data dell_7212_tps68470_vio_reg_init_data = {
> .apply_uV = 1,
> .valid_ops_mask = REGULATOR_CHANGE_STATUS,
> },
> - .num_consumer_supplies = 0,
> - .consumer_supplies = NULL,
> };
>
> static const struct regulator_init_data dell_7212_tps68470_vsio_reg_init_data = {
prev parent reply other threads:[~2026-03-27 14:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 13:10 [PATCH 1/1] platform: int3472: Drop redundant initialisation to 0 and NULL Sakari Ailus
2026-03-17 14:07 ` johannes.goede
2026-03-27 14:50 ` Dan Scally [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=732143c6-3cca-4b47-8e7f-7f8d1499d901@ideasonboard.com \
--to=dan.scally@ideasonboard.com \
--cc=antti.laakso@linux.intel.com \
--cc=brgl@kernel.org \
--cc=hao.yao@intel.com \
--cc=hverkuil+cisco@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jimmy.su@intel.com \
--cc=kees@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=miguel.vadillo@intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=ribalda@chromium.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).