From: Mark Brown <broonie@kernel.org>
To: Linus Walleij <linusw@kernel.org>
Cc: Bartosz Golaszewski <brgl@kernel.org>,
linux-sound@vger.kernel.org, linux-gpio@vger.kernel.org,
Philipp Zabel <p.zabel@pengutronix.de>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: uda1380: Modernize the driver
Date: Tue, 31 Mar 2026 15:36:09 +0100 [thread overview]
Message-ID: <73689388-a323-4ef3-929c-8f8f15455116@sirena.org.uk> (raw)
In-Reply-To: <CAD++jLniBA_9NzG3BwNpTpT8fC3QRF0yiM_=Wq4u409_fqWVcQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 851 bytes --]
On Mon, Mar 30, 2026 at 10:56:53AM +0200, Linus Walleij wrote:
> On Mon, Mar 30, 2026 at 10:45 AM Bartosz Golaszewski <brgl@kernel.org> wrote:
> > $ git grep nxp,uda1380
> > arch/arm/boot/dts/nxp/lpc/lpc3250-ea3250.dts: compatible =
> > "nxp,uda1380";
> > arch/arm/boot/dts/nxp/lpc/lpc3250-phy3250.dts: compatible =
> > "nxp,uda1380";
> > I think these count as in-tree users of the driver, right? The compatible is
> > not described in bindings but I think this still looks as ABI.
> Oh I didn't see *those*!
> Well we could just delete the platform data handling instead but fixing
> this properly is probably more fun and helpful.
Note that at least the ea3250 is trying to use wspll as the sysclk,
though the DT parsing code doesn't appear to actually exist so I'm not
expecting it to work currently.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2026-03-31 14:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 8:05 [PATCH] ASoC: uda1380: Modernize the driver Linus Walleij
2026-03-30 8:45 ` Bartosz Golaszewski
2026-03-30 8:56 ` Linus Walleij
2026-03-31 14:36 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73689388-a323-4ef3-929c-8f8f15455116@sirena.org.uk \
--to=broonie@kernel.org \
--cc=brgl@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).