Linux-GPIO Archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Oleksij Rempel <o.rempel@pengutronix.de>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Lee Jones <lee@kernel.org>,
	Peter Rosin <peda@axentia.se>, Linus Walleij <linusw@kernel.org>
Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org,
	linux-gpio@vger.kernel.org, David Jander <david@protonic.nl>
Subject: Re: [PATCH v8 0/6] mfd: Add support for NXP MC33978/MC34978 MSDI
Date: Sun, 29 Mar 2026 08:34:31 -0700	[thread overview]
Message-ID: <8291919d-c5ea-42ab-b2e5-2dfa16c23698@roeck-us.net> (raw)
In-Reply-To: <20260329090601.532477-1-o.rempel@pengutronix.de>

Hi Oleksij,

On 3/29/26 02:05, Oleksij Rempel wrote:
> changes v7:
> - drop gpiolib irq fix and make pinctrl more robust against NULL point
>    dereference.
> 
> This series adds support for the NXP MC33978/MC34978 Multiple Switch Detection
> Interface (MSDI) via the MFD framework.
> 
> Architecture overview:
> * mfd: Core driver handling 2-frame pipelined SPI, regulator sequencing, and
>    linear irq_domain. Harvests status bits from SPI MISO MSB.
> * pinctrl: Exposes 22 physical switch inputs as standard GPIOs. Proxies IRQs to
>    the MFD domain.
> * hwmon: Exposes thermal limits, VBATP/VDDQ voltage boundaries, and dynamic
>    fault alarms.
> * mux: Controls the 24-to-1 AMUX routing analog signals (switch voltages,
>    temperature, VBATP) to an external ADC.
> 
> Initial pinctrl implementation by David Jander, reworked into this MFD
> architecture.
> 

I Acked the hwmon driver, but Sashiko is still not happy with several of the other
patches in the series:

https://sashiko.dev/#/patchset/20260329090601.532477-1-o.rempel%40pengutronix.de

If the remaining issues are false positives, please let Roman and/or me know.

Thanks,
Guenter


  parent reply	other threads:[~2026-03-29 15:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-29  9:05 [PATCH v8 0/6] mfd: Add support for NXP MC33978/MC34978 MSDI Oleksij Rempel
2026-03-29  9:05 ` [PATCH v8 1/6] dt-bindings: pinctrl: add " Oleksij Rempel
2026-03-29 10:30   ` Rob Herring (Arm)
2026-03-29  9:05 ` [PATCH v8 2/6] mfd: add NXP MC33978/MC34978 core driver Oleksij Rempel
2026-03-29  9:05 ` [PATCH v8 3/6] pinctrl: core: Make pin group callbacks optional for pin-only drivers Oleksij Rempel
2026-03-29  9:05 ` [PATCH v8 4/6] pinctrl: add NXP MC33978/MC34978 pinctrl driver Oleksij Rempel
2026-03-29  9:06 ` [PATCH v8 5/6] hwmon: add NXP MC33978/MC34978 driver Oleksij Rempel
2026-03-29 15:31   ` Guenter Roeck
2026-03-29  9:06 ` [PATCH v8 6/6] mux: add NXP MC33978/MC34978 AMUX driver Oleksij Rempel
2026-03-29 15:34 ` Guenter Roeck [this message]
2026-03-31 15:13   ` [PATCH v8 0/6] mfd: Add support for NXP MC33978/MC34978 MSDI Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8291919d-c5ea-42ab-b2e5-2dfa16c23698@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=conor+dt@kernel.org \
    --cc=david@protonic.nl \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=peda@axentia.se \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).