From: Hans de Goede <hdegoede@redhat.com>
To: Andy Shevchenko <andy@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 1/6] mmc: core: Add mmc_gpiod_set_cd_config() function
Date: Mon, 8 Apr 2024 17:21:12 +0200 [thread overview]
Message-ID: <94cfa198-cad6-47c2-81e0-1b33898bbc8e@redhat.com> (raw)
In-Reply-To: <ZhQKMpL3a24o1fjO@smile.fi.intel.com>
Hi,
On 4/8/24 5:16 PM, Andy Shevchenko wrote:
> On Sun, Apr 07, 2024 at 10:04:48PM +0200, Hans de Goede wrote:
>> Some mmc host drivers may need to fixup a card-detection GPIO's config
>> to e.g. enable the GPIO controllers builtin pull-up resistor on devices
>> where the firmware description of the GPIO is broken (e.g. GpioInt with
>> PullNone instead of PullUp in ACPI DSDT).
>>
>> Since this is the exception rather then the rule adding a config
>> parameter to mmc_gpiod_request_cd() seems undesirable, so instead
>> add a new mmc_gpiod_set_cd_config() function. This is simply a wrapper
>> to call gpiod_set_config() on the card-detect GPIO acquired through
>> mmc_gpiod_request_cd().
>
> ...
>
>> int mmc_gpiod_request_cd(struct mmc_host *host, const char *con_id,
>> unsigned int idx, bool override_active_level,
>> unsigned int debounce);
>> +int mmc_gpiod_set_cd_config(struct mmc_host *host, unsigned long config);
>
> A nit, can we group it with...
>
>> int mmc_gpiod_request_ro(struct mmc_host *host, const char *con_id,
>> unsigned int idx, unsigned int debounce);
>> void mmc_gpio_set_cd_isr(struct mmc_host *host,
>
> ...this one, as request ops vs. set_cd ones?
I actually deliberately grouped it with mmc_gpiod_request_cd() since
it operates on the gpiod requested by that / since this is sorta an
alternative to just adding a config param to mmc_gpiod_request_cd()
mirroring the existing debounce parameter.
With that said I've no objections against moving it either. So whatever
you prefer.
Regards,
Hans
next prev parent reply other threads:[~2024-04-08 15:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-07 20:04 [PATCH 1/6] mmc: core: Add mmc_gpiod_set_cd_config() function Hans de Goede
2024-04-07 20:04 ` [PATCH 2/6] mmc: sdhci-acpi: Sort DMI quirks alphabetically Hans de Goede
2024-04-07 20:04 ` [PATCH 3/6] mmc: sdhci-acpi: Fix Lenovo Yoga Tablet 2 Pro 1380 sdcard slot not working Hans de Goede
2024-04-07 20:04 ` [PATCH 4/6] mmc: sdhci-acpi: Disable UHS/1.8V modes on Lenovo Yoga Tablet 2 series sdcard slot Hans de Goede
2024-04-08 15:19 ` Andy Shevchenko
2024-04-08 15:22 ` Hans de Goede
2024-04-08 15:26 ` Andy Shevchenko
2024-04-07 20:04 ` [PATCH 5/6] mmc: sdhci-acpi: Disable write protect detection on Toshiba WT10-A Hans de Goede
2024-04-07 20:04 ` [PATCH 6/6] mmc: sdhci-acpi: Add quirk to enable pull-up on the card-detect GPIO on Asus T100TA Hans de Goede
2024-04-08 15:22 ` Andy Shevchenko
2024-04-08 15:16 ` [PATCH 1/6] mmc: core: Add mmc_gpiod_set_cd_config() function Andy Shevchenko
2024-04-08 15:21 ` Hans de Goede [this message]
2024-04-08 15:23 ` Andy Shevchenko
2024-04-08 15:27 ` Hans de Goede
2024-04-08 15:35 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94cfa198-cad6-47c2-81e0-1b33898bbc8e@redhat.com \
--to=hdegoede@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=andy@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).