From: Linus Walleij <linus.walleij@linaro.org>
To: Stefan Wahren <wahrenst@gmx.net>
Cc: Florian Fainelli <florian.fainelli@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
linux-gpio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Bartosz Golaszewski <brgl@bgdev.pl>,
Phil Elwell <phil@raspberrypi.com>,
Kent Gibson <warthog618@gmail.com>
Subject: Re: [PATCH V2] pinctrl: bcm2835: Make pin freeing behavior configurable
Date: Mon, 6 May 2024 08:14:28 +0200 [thread overview]
Message-ID: <CACRpkdY5pbtCU=hFaQ0MmYqMy5xWCxV6HPcEoRMMNEDL657crQ@mail.gmail.com> (raw)
In-Reply-To: <20240503062745.11298-1-wahrenst@gmx.net>
On Fri, May 3, 2024 at 8:28 AM Stefan Wahren <wahrenst@gmx.net> wrote:
> Until now after a bcm2835 pin was freed its pinmux was set to GPIO_IN.
> So in case it was configured as GPIO_OUT before the configured output
> level also get lost. As long as GPIO sysfs was used this wasn't
> actually a problem because the pins and their possible output level
> were kept by sysfs.
>
> Since more and more Raspberry Pi users start using libgpiod they are
> confused about this behavior. So make the pin freeing behavior of
> GPIO_OUT configurable via module parameter. In case
> pinctrl-bcm2835.persist_gpio_outputs is set to 1, the output level is
> kept.
>
> This patch based on the downstream work of Phil Elwell.
>
> Link: https://github.com/raspberrypi/linux/pull/6117
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
Patch applied!
Yours,
Linus Walleij
next prev parent reply other threads:[~2024-05-06 6:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 6:27 [PATCH V2] pinctrl: bcm2835: Make pin freeing behavior configurable Stefan Wahren
2024-05-06 6:14 ` Linus Walleij [this message]
2024-05-06 20:31 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdY5pbtCU=hFaQ0MmYqMy5xWCxV6HPcEoRMMNEDL657crQ@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brgl@bgdev.pl \
--cc=florian.fainelli@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=phil@raspberrypi.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=wahrenst@gmx.net \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).