* [PATCH] pinctrl: qcom: Add "and" to PIN_CONFIG_INPUT_ENABLE comment
@ 2023-04-07 21:29 Douglas Anderson
2023-04-07 21:47 ` Stephen Boyd
2023-04-10 22:23 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Douglas Anderson @ 2023-04-07 21:29 UTC (permalink / raw
To: Linus Walleij
Cc: Stephen Boyd, Douglas Anderson, Andy Gross, Bjorn Andersson,
Konrad Dybcio, linux-arm-msm, linux-gpio, linux-kernel
The comment recently added talking about PIN_CONFIG_INPUT_ENABLE is
clearly missing the word "and". Comments live forever, so let's fix
it.
Fixes: e49eabe3e13f ("pinctrl: qcom: Support OUTPUT_ENABLE; deprecate INPUT_ENABLE")
Reported-by: Stephen Boyd <swboyd@chromium.org>
Link: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/4409769/comment/9a1d5def_e1e71db7/
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
drivers/pinctrl/qcom/pinctrl-msm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
index 65a172786ae0..c5f52d4f7781 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm.c
@@ -517,7 +517,7 @@ static int msm_config_group_set(struct pinctrl_dev *pctldev,
* The points above, explain why this _should_ be a
* no-op. However, for historical reasons and to
* support old device trees, we'll violate the docs
- * still affect the output.
+ * and still affect the output.
*
* It should further be noted that this old historical
* behavior actually overrides arg to 0. That means
--
2.40.0.577.gac1e443424-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: qcom: Add "and" to PIN_CONFIG_INPUT_ENABLE comment
2023-04-07 21:29 [PATCH] pinctrl: qcom: Add "and" to PIN_CONFIG_INPUT_ENABLE comment Douglas Anderson
@ 2023-04-07 21:47 ` Stephen Boyd
2023-04-10 22:23 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2023-04-07 21:47 UTC (permalink / raw
To: Douglas Anderson, Linus Walleij
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, linux-arm-msm,
linux-gpio, linux-kernel
Quoting Douglas Anderson (2023-04-07 14:29:14)
> The comment recently added talking about PIN_CONFIG_INPUT_ENABLE is
> clearly missing the word "and". Comments live forever, so let's fix
> it.
>
> Fixes: e49eabe3e13f ("pinctrl: qcom: Support OUTPUT_ENABLE; deprecate INPUT_ENABLE")
> Reported-by: Stephen Boyd <swboyd@chromium.org>
> Link: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/4409769/comment/9a1d5def_e1e71db7/
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: qcom: Add "and" to PIN_CONFIG_INPUT_ENABLE comment
2023-04-07 21:29 [PATCH] pinctrl: qcom: Add "and" to PIN_CONFIG_INPUT_ENABLE comment Douglas Anderson
2023-04-07 21:47 ` Stephen Boyd
@ 2023-04-10 22:23 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2023-04-10 22:23 UTC (permalink / raw
To: Douglas Anderson
Cc: Stephen Boyd, Andy Gross, Bjorn Andersson, Konrad Dybcio,
linux-arm-msm, linux-gpio, linux-kernel
On Fri, Apr 7, 2023 at 11:29 PM Douglas Anderson <dianders@chromium.org> wrote:
> The comment recently added talking about PIN_CONFIG_INPUT_ENABLE is
> clearly missing the word "and". Comments live forever, so let's fix
> it.
>
> Fixes: e49eabe3e13f ("pinctrl: qcom: Support OUTPUT_ENABLE; deprecate INPUT_ENABLE")
> Reported-by: Stephen Boyd <swboyd@chromium.org>
> Link: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/4409769/comment/9a1d5def_e1e71db7/
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-10 22:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-07 21:29 [PATCH] pinctrl: qcom: Add "and" to PIN_CONFIG_INPUT_ENABLE comment Douglas Anderson
2023-04-07 21:47 ` Stephen Boyd
2023-04-10 22:23 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).