From: Linus Walleij <linus.walleij@linaro.org>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Andy Shevchenko <andriy.shevchenko@intel.com>,
Zeng Heng <zengheng4@huawei.com>,
linux-kernel@vger.kernel.org, xiexiuqi@huawei.com,
linux-gpio@vger.kernel.org, weiyongjun1@huawei.com,
liwei391@huawei.com
Subject: Re: [PATCH] pinctrl: devicetree: fix refcount leak in pinctrl_dt_to_map()
Date: Fri, 19 Apr 2024 15:24:52 +0200 [thread overview]
Message-ID: <CACRpkdb2YCrG_wJtdSNhqUJt5x-fPSb4A9uaU6DmAOm3roFN0Q@mail.gmail.com> (raw)
In-Reply-To: <fe83e07f-ca28-4c00-9b1b-7d16c63bad62@moroto.mountain>
On Wed, Apr 17, 2024 at 7:49 PM Dan Carpenter <dan.carpenter@linaro.org> wrote:
> Probably we should add a comment to say:
>
> /* Return -ENODEV if the property 'pinctrl-0' is not present. */
Would you mind sending a oneliner on top to fix this?
Yours,
Linus Walleij
prev parent reply other threads:[~2024-04-19 13:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 10:53 [PATCH] pinctrl: devicetree: fix refcount leak in pinctrl_dt_to_map() Zeng Heng
2024-04-15 11:08 ` Dan Carpenter
2024-04-15 16:36 ` Markus Elfring
2024-04-16 13:33 ` Linus Walleij
2024-04-17 15:30 ` Andy Shevchenko
2024-04-17 15:38 ` Dan Carpenter
2024-04-17 17:12 ` Andy Shevchenko
2024-04-17 17:49 ` Dan Carpenter
2024-04-18 10:05 ` Andy Shevchenko
2024-04-19 13:24 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdb2YCrG_wJtdSNhqUJt5x-fPSb4A9uaU6DmAOm3roFN0Q@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=andriy.shevchenko@intel.com \
--cc=dan.carpenter@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liwei391@huawei.com \
--cc=weiyongjun1@huawei.com \
--cc=xiexiuqi@huawei.com \
--cc=zengheng4@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).