From: Linus Walleij <linusw@kernel.org>
To: Yu-Chun Lin <eleanor.lin@realtek.com>
Cc: brgl@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, afaerber@suse.com, tychang@realtek.com,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-realtek-soc@lists.infradead.org, cy.huang@realtek.com,
stanley_chang@realtek.com, james.tai@realtek.com
Subject: Re: [PATCH 3/3] gpio: realtek: Add driver for Realtek DHC RTD1625 SoC
Date: Tue, 7 Apr 2026 09:27:20 +0200 [thread overview]
Message-ID: <CAD++jL=Gr5szR9bNeLHGJh_Hku6FrW7f=sBtWi9nzui=VS3Y-Q@mail.gmail.com> (raw)
In-Reply-To: <20260331113835.3510341-4-eleanor.lin@realtek.com>
On Tue, Mar 31, 2026 at 1:38 PM Yu-Chun Lin <eleanor.lin@realtek.com> wrote:
> From: Tzuyi Chang <tychang@realtek.com>
>
> Add support for the GPIO controller found on Realtek DHC RTD1625 SoCs.
>
> Unlike the existing Realtek GPIO driver (drivers/gpio/gpio-rtd.c),
> which manages pins via shared bank registers, the RTD1625 introduces
> a per-pin register architecture. Each GPIO line now has its own
> dedicated 32-bit control register to manage configuration independently,
> including direction, output value, input value, interrupt enable, and
> debounce. Therefore, this distinct hardware design requires a separate
> driver.
>
> Signed-off-by: Tzuyi Chang <tychang@realtek.com>
> Signed-off-by: Yu-Chun Lin <eleanor.lin@realtek.com>
With Bartosz comment addressed:
Reviewed-by: Linus Walleij <linusw@kernel.org>
Yours,
Linus Walleij
prev parent reply other threads:[~2026-04-07 7:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 11:38 [PATCH 0/3] gpio: realtek: Add support for Realtek DHC RTD1625 Yu-Chun Lin
2026-03-31 11:38 ` [PATCH 1/3] dt-bindings: gpio: realtek: Add realtek,rtd1625-gpio Yu-Chun Lin
2026-04-01 7:47 ` Krzysztof Kozlowski
2026-04-01 11:10 ` Yu-Chun Lin [林祐君]
2026-04-01 11:12 ` Krzysztof Kozlowski
2026-03-31 11:38 ` [PATCH 2/3] arm64: dts: realtek: Add GPIO support for RTD1625 Yu-Chun Lin
2026-04-01 7:49 ` Krzysztof Kozlowski
2026-04-01 11:21 ` Yu-Chun Lin [林祐君]
2026-03-31 11:38 ` [PATCH 3/3] gpio: realtek: Add driver for Realtek DHC RTD1625 SoC Yu-Chun Lin
2026-03-31 12:15 ` Bartosz Golaszewski
2026-04-07 7:27 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD++jL=Gr5szR9bNeLHGJh_Hku6FrW7f=sBtWi9nzui=VS3Y-Q@mail.gmail.com' \
--to=linusw@kernel.org \
--cc=afaerber@suse.com \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cy.huang@realtek.com \
--cc=devicetree@vger.kernel.org \
--cc=eleanor.lin@realtek.com \
--cc=james.tai@realtek.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-realtek-soc@lists.infradead.org \
--cc=robh@kernel.org \
--cc=stanley_chang@realtek.com \
--cc=tychang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).