From: Chen-Yu Tsai <wenst@chromium.org>
To: Luca Leonardo Scorcia <l.scorcia@gmail.com>
Cc: linux-mediatek@lists.infradead.org,
Fabien Parent <parent.f@gmail.com>,
Val Packett <val@packett.cool>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Sen Chu <sen.chu@mediatek.com>,
Sean Wang <sean.wang@mediatek.com>,
Macpaul Lin <macpaul.lin@mediatek.com>,
Lee Jones <lee@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Linus Walleij <linusw@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Gary Bisson <bisson.gary@gmail.com>,
Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>,
Julien Massot <julien.massot@collabora.com>,
Chen Zhong <chen.zhong@mediatek.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v3 7/9] regulator: mt6392: Add support for MT6392 regulator
Date: Mon, 30 Mar 2026 17:35:54 +0800 [thread overview]
Message-ID: <CAGXv+5HRWRW=+Mk2z4qCPrF7zFax9zQJ70Q4ihR6PkWJP0OUrg@mail.gmail.com> (raw)
In-Reply-To: <CAORyz2J355NZH=7iQ9sTDBhAmtjP7xTpXe21_3Z9J_R5YvdXAQ@mail.gmail.com>
On Mon, Mar 30, 2026 at 3:39 PM Luca Leonardo Scorcia
<l.scorcia@gmail.com> wrote:
>
> Il giorno gio 19 mar 2026 alle ore 06:04 Chen-Yu Tsai
> <wenst@chromium.org> ha scritto:
>
> > If this PMIC is anything like the MT6358, then it has 0.01V fine
> > tuning for most if not all the LDOs. It is sometimes needed as
> > a rail may have a 0.04V boost that would otherwise be invisible
> > to the system. And then if you have something like 3.04V set in
> > the DT constraints, you end up with something the regulator driver
> > doesn't support, but the hardware does.
> >
> > Please see how it's done in the MT6358 driver. I spent a lot of
> > time on that driver to make it actually support the full range
> > of voltages, and describing the supplies.
> >
>
> I had a good look at the datasheet (MT6392 PMIC Datasheet v1.0 08 Dec.
> 2016) and unfortunately I did not see any fine tuning option in there.
> I'm sure this data sheet is not perfect as it's missing some regulator
> registers that are clearly used in the Android sources, but there's no
> mention of fine tuning in that code either. I guess it does not have
> that capability.
Well, thanks for looking. FWIW on the MT6358 / MT6366, the main voltage
control and the fine tuning are mostly in the same register. The fine
tuning is described as "calibrates output voltage" from +00mV to +100mV.
I looked into this because the LDO table shows some of the default voltages
with 0.01V precision, but the main voltage controls only have 0.1V precision.
ChenYu
> I will shortly submit v4 that hopefully addresses the rest of the comments.
>
> Thanks for your help!
> --
> Luca Leonardo Scorcia
> l.scorcia@gmail.com
next prev parent reply other threads:[~2026-03-30 9:36 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 18:43 [PATCH v3 0/9] Add support for mt6392 PMIC Luca Leonardo Scorcia
2026-03-17 18:43 ` [PATCH v3 1/9] dt-bindings: mfd: mt6397: Add bindings for MT6392 PMIC Luca Leonardo Scorcia
2026-03-18 7:37 ` Krzysztof Kozlowski
2026-03-18 7:47 ` Krzysztof Kozlowski
2026-03-18 12:39 ` AngeloGioacchino Del Regno
2026-03-17 18:43 ` [PATCH v3 2/9] dt-bindings: input: mtk-pmic-keys: add MT6392 binding definition Luca Leonardo Scorcia
2026-03-18 12:39 ` AngeloGioacchino Del Regno
2026-03-17 18:43 ` [PATCH v3 3/9] dt-bindings: regulator: Document MediaTek MT6392 PMIC Regulators Luca Leonardo Scorcia
2026-03-18 7:43 ` Krzysztof Kozlowski
2026-03-18 21:25 ` Luca Leonardo Scorcia
2026-03-18 22:14 ` Krzysztof Kozlowski
2026-03-19 4:53 ` Chen-Yu Tsai
2026-03-19 7:23 ` Krzysztof Kozlowski
2026-03-18 12:39 ` AngeloGioacchino Del Regno
2026-03-19 4:56 ` Chen-Yu Tsai
2026-03-17 18:43 ` [PATCH v3 4/9] dt-bindings: pinctrl: mt65xx: Document MT6392 pinctrl Luca Leonardo Scorcia
2026-03-18 12:39 ` AngeloGioacchino Del Regno
2026-03-17 18:43 ` [PATCH v3 5/9] mfd: mt6397: Add support for MT6392 pmic Luca Leonardo Scorcia
2026-03-18 12:39 ` AngeloGioacchino Del Regno
2026-03-26 12:10 ` Lee Jones
2026-03-17 18:43 ` [PATCH v3 6/9] input: keyboard: mtk-pmic-keys: add MT6392 support Luca Leonardo Scorcia
2026-03-18 12:39 ` AngeloGioacchino Del Regno
2026-03-17 18:43 ` [PATCH v3 7/9] regulator: mt6392: Add support for MT6392 regulator Luca Leonardo Scorcia
2026-03-18 12:39 ` AngeloGioacchino Del Regno
2026-03-19 5:04 ` Chen-Yu Tsai
2026-03-30 7:39 ` Luca Leonardo Scorcia
2026-03-30 9:35 ` Chen-Yu Tsai [this message]
2026-03-17 18:43 ` [PATCH v3 8/9] pinctrl: mediatek: mt6397: Add support for MT6392 variant Luca Leonardo Scorcia
2026-03-18 12:38 ` AngeloGioacchino Del Regno
2026-03-17 18:43 ` [PATCH v3 9/9] arm64: dts: mt6392: add mt6392 PMIC dtsi Luca Leonardo Scorcia
2026-03-18 12:39 ` AngeloGioacchino Del Regno
2026-03-18 13:54 ` Chen-Yu Tsai
2026-03-18 17:22 ` AngeloGioacchino Del Regno
2026-03-26 5:43 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGXv+5HRWRW=+Mk2z4qCPrF7zFax9zQJ70Q4ihR6PkWJP0OUrg@mail.gmail.com' \
--to=wenst@chromium.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bisson.gary@gmail.com \
--cc=broonie@kernel.org \
--cc=chen.zhong@mediatek.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=julien.massot@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=l.scorcia@gmail.com \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=louisalexis.eyraud@collabora.com \
--cc=macpaul.lin@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=parent.f@gmail.com \
--cc=robh@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=sen.chu@mediatek.com \
--cc=val@packett.cool \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).