From: Peng Fan <peng.fan@nxp.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
"Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Cristian Marussi <cristian.marussi@arm.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Dan Carpenter <dan.carpenter@linaro.org>,
Dhruva Gole <d-gole@ti.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Oleksii Moisieiev <oleksii_moisieiev@epam.com>
Subject: RE: [PATCH v10 4/4] pinctrl: Implementation of the generic scmi-pinctrl driver
Date: Tue, 16 Apr 2024 06:47:02 +0000 [thread overview]
Message-ID: <DU0PR04MB941773C6DFD95237ED051E8A88082@DU0PR04MB9417.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CAHp75VdoaL-66vDFeDWXg5V0XnL45F_JQZ_BNeaaOcSwQz5gnQ@mail.gmail.com>
> Subject: Re: [PATCH v10 4/4] pinctrl: Implementation of the generic scmi-
> pinctrl driver
>
> On Mon, Apr 15, 2024 at 11:43 AM Peng Fan (OSS) <peng.fan@oss.nxp.com>
> wrote:
> >
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > scmi-pinctrl driver implements pinctrl driver interface and using SCMI
> > protocol to redirect messages from pinctrl subsystem SDK to SCMI
> > platform firmware, which does the changes in HW.
>
> Below are some cosmetics, but in general LGTM, thanks!
> Reviewed-by: Andy Shevchenko <andy@kernel.org>
Thanks for help reviewing the patchset.
>
> ...
>
> > +#include <linux/device.h>
> > +#include <linux/dev_printk.h>
>
> The second one is guaranteed to be included by the first one, so dev_printk.h
> can be removed.
Fix in v11.
>
> > +#include <linux/err.h>
>
> + errno.h as ENOTSUPP is defined there and surprisingly err.h doesn't
> include that.
Ok, include errno.h in v11.
>
> + mod_devicetable.h (for the ID table type definition)
Fix in v11.
>
> > +#include <linux/module.h>
> > +#include <linux/scmi_protocol.h>
> > +#include <linux/slab.h>
> > +#include <linux/types.h>
>
> ...
>
> > +/* Define num configs, if not large than 4 use stack, else use
> > +kcalloc */
>
> kcalloc()
Fix in v11.
>
> ...
>
> > + ret = pinctrl_ops->settings_get_one(pmx->ph, pin, PIN_TYPE, type,
> > + &config_value);
> > + if (ret) {
> > + /* Convert SCMI error code to PINCTRL expected error code */
> > + if (ret == -EOPNOTSUPP)
> > + ret = -ENOTSUPP;
> > + return ret;
> > + }
>
> It can be split as
>
> ret = pinctrl_ops->settings_get_one(pmx->ph, pin, PIN_TYPE, type,
> &config_value);
> /* Convert SCMI error code to PINCTRL expected error code */
> if (ret == -EOPNOTSUPP)
> return -ENOTSUPP;
> if (ret)
> return ret;
Fix in v11.
>
> ...
>
> > + ret = pinctrl_ops->settings_get_one(pmx->ph, group, GROUP_TYPE,
> type,
> > + &config_value);
> > + if (ret) {
> > + /* Convert SCMI error code to PINCTRL expected error code */
> > + if (ret == -EOPNOTSUPP)
> > + ret = -ENOTSUPP;
> > + return ret;
> > + }
>
> As per above.
Ditto.
Thanks,
Peng.
>
> --
> With Best Regards,
> Andy Shevchenko
next prev parent reply other threads:[~2024-04-16 6:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 8:50 [PATCH v10 0/4] firmware: arm_scmi: Add SCMI v3.2 pincontrol protocol basic support Peng Fan (OSS)
2024-04-15 8:50 ` [PATCH v10 1/4] firmware: arm_scmi: introduce helper get_max_msg_size Peng Fan (OSS)
2024-04-15 8:50 ` [PATCH v10 2/4] dt-bindings: firmware: arm,scmi: support pinctrl protocol Peng Fan (OSS)
2024-04-15 8:50 ` [PATCH v10 3/4] firmware: arm_scmi: Add SCMI v3.2 pincontrol protocol basic support Peng Fan (OSS)
2024-04-15 8:50 ` [PATCH v10 4/4] pinctrl: Implementation of the generic scmi-pinctrl driver Peng Fan (OSS)
2024-04-15 14:00 ` Andy Shevchenko
2024-04-16 6:47 ` Peng Fan [this message]
2024-04-16 18:20 ` [PATCH v10 0/4] firmware: arm_scmi: Add SCMI v3.2 pincontrol protocol basic support Dan Carpenter
2024-04-17 6:38 ` Cristian Marussi
2024-04-17 12:15 ` Peng Fan
2024-04-17 12:42 ` Dan Carpenter
2024-04-17 13:07 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DU0PR04MB941773C6DFD95237ED051E8A88082@DU0PR04MB9417.eurprd04.prod.outlook.com \
--to=peng.fan@nxp.com \
--cc=andy.shevchenko@gmail.com \
--cc=conor+dt@kernel.org \
--cc=cristian.marussi@arm.com \
--cc=d-gole@ti.com \
--cc=dan.carpenter@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksii_moisieiev@epam.com \
--cc=peng.fan@oss.nxp.com \
--cc=robh@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).