From: Etienne Buira <etienne.buira@free.fr>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: brgl@bgdev.pl, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][RFC][resend after bogus] gpio-syscon: do not report bogus error
Date: Sat, 13 Apr 2024 13:31:29 +0200 [thread overview]
Message-ID: <ZhptEWb7tD5pummq@Z926fQmE5jqhFMgp6> (raw)
In-Reply-To: <CACRpkdbTdGajQLSGDkD0cWRG+79tpojYkdyF3t0jD7_WEDtQLw@mail.gmail.com>
On Fri, Apr 12, 2024 at 12:44:34PM +0200, Linus Walleij wrote:
> Hi Etienne,
>
> thanks for your patch!
>
> On Thu, Apr 11, 2024 at 5:35 PM Etienne Buira <etienne.buira@free.fr> wrote:
>
> > Do not call dev_err when gpio,syscon-dev is not set albeit unneeded.
> > gpio-syscon is used with rk3328 chip, but this iomem region is
> > documented in
> > Documentation/devicetree/bindings/gpio/rockchip,rk3328-grf-gpio.yaml and
> > does not look like to require gpio,syscon-dev setting.
> >
> > Signed-off-by: Etienne Buira <etienne.buira@free.fr>
> > X-Prefers: kind explanations over rotten tomatoes
../..
> So indeed the parent is a sycon, and syscon_node_to_regmap(np->parent) will
> be used to populate priv->syscon on RK3328.
../..
> if (!has_parent_syscon) {
> (...)
>
> What do you think about this?
../..
Hi Linus,
Thanks for your review.
IIUC, that would prevent calling dev_err() if, for example,
gpio,syscon-dev were forgotten from
arch/arm/boot/dts/ti/keystone/keystone-k2g.dtsi, dspgpio0 node although
it is needed and would result in funny things without notice.
Thinking twice about it, a cleaner way looks to add gpio,syscon-dev node
to rk3328.dtsi. I'll send the one-liner to relevant people (that would
be really easier if there were only one repo, with different
branches...).
Do you agree?
Regards.
Note: I'm not subscribed to list, so please To or CC me.
prev parent reply other threads:[~2024-04-13 11:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 15:34 [PATCH][RFC][resend after bogus] gpio-syscon: do not report bogus error Etienne Buira
2024-04-12 10:44 ` Linus Walleij
2024-04-13 11:31 ` Etienne Buira [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhptEWb7tD5pummq@Z926fQmE5jqhFMgp6 \
--to=etienne.buira@free.fr \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).