From: Etienne Buira <etienne.buira@free.fr>
To: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Johan Jonker <jbx6244@gmail.com>,
Dragan Simic <dsimic@manjaro.org>,
shironeko <shironeko@tesaguri.club>,
Etienne Buira <etienne.buira@free.fr>,
Jonas Karlman <jonas@kwiboo.se>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH] Avoid error message on rk3328 use
Date: Sat, 13 Apr 2024 15:56:08 +0200 [thread overview]
Message-ID: <ZhqO-DEmh-6TeHrt@Z926fQmE5jqhFMgp6> (raw)
rockchip,rk3328-grf-gpio is handled as syscon, but syscon mandates
presence of gpio,syscon-dev node (or it will call dev_err() when probed).
Correct rk3328.dtsi and related documentation to follow syscon's
expectations.
Signed-off-by: Etienne Buira <etienne.buira@free.fr>
---
.../devicetree/bindings/gpio/rockchip,rk3328-grf-gpio.yaml | 2 ++
arch/arm64/boot/dts/rockchip/rk3328.dtsi | 1 +
2 files changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/gpio/rockchip,rk3328-grf-gpio.yaml b/Documentation/devicetree/bindings/gpio/rockchip,rk3328-grf-gpio.yaml
index d8cce73ea0ae..2c878e7db900 100644
--- a/Documentation/devicetree/bindings/gpio/rockchip,rk3328-grf-gpio.yaml
+++ b/Documentation/devicetree/bindings/gpio/rockchip,rk3328-grf-gpio.yaml
@@ -38,6 +38,7 @@ required:
- compatible
- gpio-controller
- "#gpio-cells"
+ - gpio,syscon-dev
additionalProperties: false
@@ -47,4 +48,5 @@ examples:
compatible = "rockchip,rk3328-grf-gpio";
gpio-controller;
#gpio-cells = <2>;
+ gpio,syscon-dev = <&grf 0 0>;
};
diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
index b6f045069ee2..fd25d5bee19f 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
@@ -296,6 +296,7 @@ grf_gpio: gpio {
compatible = "rockchip,rk3328-grf-gpio";
gpio-controller;
#gpio-cells = <2>;
+ gpio,syscon-dev = <&grf 0 0>;
};
power: power-controller {
base-commit: 20cb38a7af88dc40095da7c2c9094da3873fea23
--
2.43.0
next reply other threads:[~2024-04-13 13:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-13 13:56 Etienne Buira [this message]
2024-04-13 15:09 ` [PATCH] Avoid error message on rk3328 use Krzysztof Kozlowski
2024-04-13 15:23 ` Etienne Buira
2024-04-13 15:49 ` Krzysztof Kozlowski
2024-04-13 16:11 ` Etienne Buira
2024-04-13 16:25 ` Diederik de Haas
2024-04-13 15:20 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhqO-DEmh-6TeHrt@Z926fQmE5jqhFMgp6 \
--to=etienne.buira@free.fr \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dsimic@manjaro.org \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
--cc=shironeko@tesaguri.club \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).