From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Laura Nao <laura.nao@collabora.com>
Cc: mika.westerberg@linux.intel.com, linus.walleij@linaro.org,
brgl@bgdev.pl, kernel@collabora.com,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-acpi@vger.kernel.org, "kernelci.org bot" <bot@kernelci.org>
Subject: Re: [PATCH] gpiolib: acpi: Add ACPI device NULL check to acpi_can_fallback_to_crs()
Date: Fri, 10 May 2024 17:46:13 +0300 [thread overview]
Message-ID: <Zj4zNefxGUGKjxha@smile.fi.intel.com> (raw)
In-Reply-To: <20240509104605.538274-1-laura.nao@collabora.com>
On Thu, May 09, 2024 at 12:46:05PM +0200, Laura Nao wrote:
> Check ACPI device for NULL inside acpi_can_fallback_to_crs(), so callers
> won't need to.
Thank you for the patch, one change seems good to have along this.
...
> /* Never allow fallback if the device has properties */
> - if (acpi_dev_has_props(adev) || adev->driver_gpios)
> + if (!adev || acpi_dev_has_props(adev) || adev->driver_gpios)
Right, since it was adev || _crs() combined.
> return false;
Now we may remove that check from __acpi_find_gpio():
--- a/drivers/gpio/gpiolib-acpi.c
+++ b/drivers/gpio/gpiolib-acpi.c
@@ -988,10 +988,10 @@ __acpi_find_gpio(struct fwnode_handle *fwnode, const char *con_id, unsigned int
}
/* Then from plain _CRS GPIOs */
- if (!adev || !can_fallback)
- return ERR_PTR(-ENOENT);
+ if (can_fallback)
+ return acpi_get_gpiod_by_index(adev, NULL, idx, info);
- return acpi_get_gpiod_by_index(adev, NULL, idx, info);
+ return ERR_PTR(-ENOENT);
}
struct gpio_desc *acpi_find_gpio(struct fwnode_handle *fwnode,
As a side effect it will make the comment better to understand.
With above suggestion applied, feel free to add mine
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
You might need to rephrase the commit message to say that
"We also move the check in additional to the moving the function call
outside of __acpi_find_gpio()."
or something similar, up to you.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-05-10 14:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 10:46 [PATCH] gpiolib: acpi: Add ACPI device NULL check to acpi_can_fallback_to_crs() Laura Nao
2024-05-09 12:55 ` AngeloGioacchino Del Regno
2024-05-10 14:46 ` Andy Shevchenko [this message]
2024-05-13 10:02 ` [PATCH] gpiolib: acpi: Add ACPI device NULL check to Laura Nao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zj4zNefxGUGKjxha@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bot@kernelci.org \
--cc=brgl@bgdev.pl \
--cc=kernel@collabora.com \
--cc=laura.nao@collabora.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).