From: William Breathitt Gray <wbg@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: linux-gpio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>
Subject: Re: GPIO drivers under drivers/char/
Date: Sat, 11 May 2024 21:41:28 +0900 [thread overview]
Message-ID: <Zj9neMiKZH9vlsKp@ishi> (raw)
In-Reply-To: <Zj5lce8vzGhJWVeA@smile.fi.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1523 bytes --]
On Fri, May 10, 2024 at 09:20:33PM +0300, Andy Shevchenko wrote:
> (Update William's email; btw, William, it seems MAINTAINERS need an update, or .mailcap)
>
> On Fri, May 10, 2024 at 08:33:53PM +0300, Andy Shevchenko wrote:
> > Hi!
> >
> > Due to patch bomb from Jens, I noticed that we have two interesting drivers
> > (and a common library) under drivers/char/. Shouldn't we move them to
> > drivers/gpio/ to keep an eye on that (with the respective update of MAINTAINERS
> > if needed)? Also William might say something about this since those are old ISA
> > (?) related ones and (perhaps?) might utilise PC-104 code.
>
> --
> With Best Regards,
> Andy Shevchenko
Thank you for the forward; I'm updating MAINTAINERS to match my
kernel.org address from now on so that we don't have this problem again
in the future. :-)
Regarding the gpio char drivers, I take it you are referring to the
nsc_gpio used by scx200_gpio and pc8736x_gpio. I agree, these should be
moved to the GPIO subsystem so they're with the old GPIO drivers (and
ported to the standard GPIO interface we have there if they're not
already).
Taking a quick look, neither of these are PC-104 devices, but rather
appear to be part of the Super I/O chip. Regardless, the driver
interface can be the same since they're both performing ioport
operations over an ISA bus essentially. You can utilize
include/linux/isa.h and leverage the module_isa_driver() like what we do
in the gpio-mm driver.
William Breathitt Gray
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2024-05-11 12:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 17:33 GPIO drivers under drivers/char/ Andy Shevchenko
2024-05-10 18:20 ` Andy Shevchenko
2024-05-11 12:41 ` William Breathitt Gray [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zj9neMiKZH9vlsKp@ishi \
--to=wbg@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).