From: Mark Brown <broonie@kernel.org>
To: Linus Walleij <linusw@kernel.org>
Cc: Bartosz Golaszewski <brgl@kernel.org>,
Srinivas Kandagatla <srini@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-gpio@vger.kernel.org, linux-sound@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] ASoC: wsa881x: Move custom workaround to gpiolib-of
Date: Fri, 27 Mar 2026 18:01:42 +0000 [thread overview]
Message-ID: <acbGBtY0zsPntsoE@sirena.co.uk> (raw)
In-Reply-To: <20260327-asoc-wsa881x-v1-1-53dc05867e6b@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 703 bytes --]
On Fri, Mar 27, 2026 at 12:10:46AM +0100, Linus Walleij wrote:
> +++ b/drivers/gpio/gpiolib-of.c
> @@ -240,6 +240,14 @@ static void of_gpio_try_fixup_polarity(const struct device_node *np,
> * treats it as "active low".
> */
> { "ti,tsc2005", "reset-gpios", false },
> +#endif
> +#if IS_ENABLED(CONFIG_SND_SOC_WSA881X)
> + /*
> + * WSA881 powerdown is always active low, but some device trees
> + * missed this when first contributed. It also has a very strange
> + * compatible.
> + */
> + { "sdw10217201000", "powerdown", false },
> #endif
The quirk in the hunk immediately above (and from a quick glance all the
others) has the -gpios suffix but this one doesn't - should it?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-03-27 18:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 23:10 [PATCH] ASoC: wsa881x: Move custom workaround to gpiolib-of Linus Walleij
2026-03-27 18:01 ` Mark Brown [this message]
2026-03-27 22:50 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acbGBtY0zsPntsoE@sirena.co.uk \
--to=broonie@kernel.org \
--cc=brgl@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).