From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Francesco Lavra <flavra@baylibre.com>
Cc: "Linus Walleij" <linusw@kernel.org>,
"Maksim Kiselev" <bigunclemax@gmail.com>,
"Sander Vanheule" <sander@svanheule.net>,
"Mike Looijmans" <mike.looijmans@topic.nl>,
"Dmitry Mastykin" <mastichi@gmail.com>,
"Evgenii Shatokhin" <e.shatokhin@yadro.com>,
"Arturas Moskvinas" <arturas.moskvinas@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Andreas Kaessens" <akaessens@gmail.com>,
"Radim Pavlik" <radim.pavlik@tbs-biometrics.com>,
"Thomas Preston" <thomas.preston@codethink.co.uk>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: mcp23s08: Disable all pin interrupts during probe
Date: Tue, 7 Apr 2026 16:47:33 +0300 [thread overview]
Message-ID: <adUK9YgJoBKY8fsm@ashevche-desk.local> (raw)
In-Reply-To: <e66a4241ad77859921a4562dec17ab932cfd79b0.camel@baylibre.com>
On Tue, Apr 07, 2026 at 09:50:39AM +0200, Francesco Lavra wrote:
> On Tue, 2026-04-07 at 08:58 +0200, Linus Walleij wrote:
> > On Mon, Mar 30, 2026 at 6:19 PM Francesco Lavra <flavra@baylibre.com>
> > wrote:
...
> > > This issue has always been present, but has been latent until commit
> > > "f9f4fda15e72" ("pinctrl: mcp23s08: init reg_defaults from HW at probe
> > > and
> > > switch cache type"), which correctly removed reg_defaults from the
> > > regmap
> > > and as a side effect changed the behavior of the interrupt handler so
> > > that
> > > the real value of the MCP_GPINTEN register is now being read from the
> > > chip
> > > instead of using a bogus 0 default value; a non-zero value for this
> > > register can trigger the invocation of a nested handler which may not
> > > exist
> > > (yet).
> > > Fix this issue by disabling all pin interrupts during initialization.
> > >
> > > Fixes: "f9f4fda15e72" ("pinctrl: mcp23s08: init reg_defaults from HW at
> > > probe and switch cache type")
>
> I realized I put stray double quotes around the commit hash.
Also you put way too many lines of backtrace. Submitting Patches recommends to
leave ~3-5 lines only (the one that bring value).
> > > Signed-off-by: Francesco Lavra <flavra@baylibre.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-07 13:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 16:19 [PATCH] pinctrl: mcp23s08: Disable all pin interrupts during probe Francesco Lavra
2026-04-07 6:58 ` Linus Walleij
2026-04-07 7:50 ` Francesco Lavra
2026-04-07 9:30 ` Linus Walleij
2026-04-07 13:47 ` Andy Shevchenko [this message]
2026-04-07 10:17 ` Mike Looijmans
2026-04-07 12:59 ` Francesco Lavra
2026-04-07 13:44 ` Mike Looijmans
2026-04-07 22:21 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adUK9YgJoBKY8fsm@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=akaessens@gmail.com \
--cc=arturas.moskvinas@gmail.com \
--cc=bigunclemax@gmail.com \
--cc=e.shatokhin@yadro.com \
--cc=flavra@baylibre.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mastichi@gmail.com \
--cc=mike.looijmans@topic.nl \
--cc=radim.pavlik@tbs-biometrics.com \
--cc=sander@svanheule.net \
--cc=thomas.preston@codethink.co.uk \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).