Linux-GPIO Archive mirror
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Esben Haabendal" <esben@geanix.com>
Cc: "Russell King" <linux@armlinux.org.uk>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Dong Aisheng" <aisheng.dong@nxp.com>,
	"Jacky Bai" <ping.bai@nxp.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Rasmus Villemoes" <rasmus.villemoes@prevas.dk>,
	linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,
	linux-kernel@vger.kernel.org,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] pinctrl: freescale: Use CONFIG_SOC_IMXRT to guard i.MX RT1xxx drivers
Date: Tue, 07 May 2024 09:43:33 +0200	[thread overview]
Message-ID: <cfd19433-c8de-4157-bdde-dcb6aa490792@app.fastmail.com> (raw)
In-Reply-To: <87r0eef4xz.fsf@geanix.com>

On Tue, May 7, 2024, at 09:37, Esben Haabendal wrote:
> "Arnd Bergmann" <arnd@arndb.de> writes:
>
>> On Mon, May 6, 2024, at 12:23, Esben Haabendal wrote:
>>>
>>>  config PINCTRL_IMXRT1050
>>>  	bool "IMXRT1050 pinctrl driver"
>>> -	depends on ARCH_MXC
>>> +	depends on SOC_IMXRT
>>> +	default SOC_IMXRT
>>>  	select PINCTRL_IMX
>>>  	help
>>>  	  Say Y here to enable the imxrt1050 pinctrl driver
>>
>> Maybe make this
>>
>>        depends on SOC_IMXRT || COMPILE_TEST
>
> That is done in patch 3/3.
>
>> I see that all the i.MX pinctrl drivers are currently missing
>> this, but a lot of other platforms have the ||COMPILE_TEST
>> bit so it gets included in x86 allmodconfig tests that
>> often gets run before sending or merging changes.
>
> Take a look at patch 3/3 in this series. It does a wholesale addition of
> ||COMPILE_TEST to these drivers.

Ok, great! Sorry I missed that bit. Whole series

Acked-by: Arnd Bergmann <arnd@arndb.de>

  reply	other threads:[~2024-05-07  7:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-06 10:23 [PATCH v2 0/3] ARM: imx: only enable pinctrl as needed Esben Haabendal
2024-05-06 10:23 ` [PATCH v2 1/3] ARM: imx: Allow user to disable pinctrl Esben Haabendal
2024-05-06 10:23 ` [PATCH v2 2/3] pinctrl: freescale: Use CONFIG_SOC_IMXRT to guard i.MX RT1xxx drivers Esben Haabendal
2024-05-06 11:29   ` Arnd Bergmann
2024-05-07  7:37     ` Esben Haabendal
2024-05-07  7:43       ` Arnd Bergmann [this message]
2024-05-06 10:23 ` [PATCH v2 3/3] pinctrl: freescale: enable use with COMPILE_TEST Esben Haabendal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cfd19433-c8de-4157-bdde-dcb6aa490792@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=aisheng.dong@nxp.com \
    --cc=esben@geanix.com \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=ping.bai@nxp.com \
    --cc=rasmus.villemoes@prevas.dk \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).