Linux-GPIO Archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Jim Liu <JJLIU0@nuvoton.com>,
	openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org,
	kernel-janitors@vger.kernel.org,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Dan Carpenter <dan.carpenter@linaro.org>,
	Linus Walleij <linus.walleij@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Jim Liu <jim.t90615@gmail.com>,
	KWLIU@nuvoton.com
Subject: Re: [PATCH v3] gpio: nuvoton: Fix sgpio irq handle error
Date: Fri, 3 May 2024 18:30:12 +0200	[thread overview]
Message-ID: <f616ab40-68a1-4f80-9bb9-c80214d087c5@web.de> (raw)
In-Reply-To: <20240429070523.3160248-1-JJLIU0@nuvoton.com>

> The generic_handle_domain_irq() function calls irq_resolve_mapping()
> so calling irq_find_mapping() is duplicative and will lead to a stack
> trace and an RCU stall.

Can a wording approach (like the following) be a bit nicer?

   The generic_handle_domain_irq() function calls irq_resolve_mapping().
   Thus delete a duplicative irq_find_mapping() call
   so that a stack trace and an RCU stall will be avoided.


Regards,
Markus

      parent reply	other threads:[~2024-05-03 16:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-29  7:05 [PATCH v3] gpio: nuvoton: Fix sgpio irq handle error Jim Liu
2024-05-03  8:36 ` Linus Walleij
2024-05-03 11:56 ` Dan Carpenter
2024-05-03 16:30 ` Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f616ab40-68a1-4f80-9bb9-c80214d087c5@web.de \
    --to=markus.elfring@web.de \
    --cc=JJLIU0@nuvoton.com \
    --cc=KWLIU@nuvoton.com \
    --cc=brgl@bgdev.pl \
    --cc=dan.carpenter@linaro.org \
    --cc=jim.t90615@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).