From: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
To: Til Kaiser <mail@tk154.de>
Cc: andersson@kernel.org, linusw@kernel.org,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: qcom: ipq4019: mark gpio as a GPIO pin function
Date: Mon, 13 Apr 2026 21:08:49 +0300 [thread overview]
Message-ID: <yvwne6bgbtofqrkb2rl4akv6uzqp4gdg4gug4dfsncddibvxek@mm6losfiwyup> (raw)
In-Reply-To: <20260413135234.4067548-1-mail@tk154.de>
On Mon, Apr 13, 2026 at 03:52:34PM +0200, Til Kaiser wrote:
> The qcom pinctrl core supports marking functions that represent GPIO mode
> via PINCTRL_GPIO_PINFUNCTION(), so that strict pinmuxing does not reject
> GPIO requests for pins that are muxed to the GPIO function.
>
> ipq4019 still describes its gpio function with QCA_PIN_FUNCTION(gpio),
> so it is not treated as a GPIO pin function. As a result, GPIO consumers
> can still conflict with pinctrl states that select the "gpio" function.
>
> Add a QCA_GPIO_PIN_FUNCTION() helper and use it for the ipq4019 gpio
> function, matching how the msm-based qcom drivers handle this.
>
> This allows ipq4019 to keep the GPIO-related pin configuration in DTS
> without tripping over strict pinmux ownership checks.
>
> Fixes: cc85cb96e2e4 ("pinctrl: qcom: make the pinmuxing strict")
> Signed-off-by: Til Kaiser <mail@tk154.de>
> ---
> drivers/pinctrl/qcom/pinctrl-ipq4019.c | 2 +-
> drivers/pinctrl/qcom/pinctrl-msm.h | 5 +++++
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2026-04-13 18:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-13 13:52 [PATCH] pinctrl: qcom: ipq4019: mark gpio as a GPIO pin function Til Kaiser
2026-04-13 18:08 ` Dmitry Baryshkov [this message]
2026-04-24 7:16 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yvwne6bgbtofqrkb2rl4akv6uzqp4gdg4gug4dfsncddibvxek@mm6losfiwyup \
--to=dmitry.baryshkov@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@tk154.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).