From: Matthew Garrett <mjg@redhat.com>
To: linux-hotplug@vger.kernel.org
Subject: [PATCH] rules: Limit USB autosuspend on USB HID devices
Date: Fri, 25 May 2012 12:01:58 +0000 [thread overview]
Message-ID: <1337947318-10412-1-git-send-email-mjg@redhat.com> (raw)
Some USB ports on external hubs may be reported as "fixed". We only want
to auto-enable this on ports that are internal to the machine, so check
the parent state as well.
---
rules/42-usb-hid-pm.rules | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/rules/42-usb-hid-pm.rules b/rules/42-usb-hid-pm.rules
index d5d5897..fc44b94 100644
--- a/rules/42-usb-hid-pm.rules
+++ b/rules/42-usb-hid-pm.rules
@@ -46,4 +46,10 @@ ACTION="add", SUBSYSTEM="usb", ATTRS{idVendor}="04b3", ATTR{idProduct}="4012
ACTION="add", SUBSYSTEM="usb", ATTR{idVendor}="14dd", ATTR{idProduct}="0002", TEST="power/control", ATTR{power/control}="auto"
# USB HID devices that are internal to the machine should also be safe to autosuspend
+
+ACTION="add", SUBSYSTEM="usb", SUBSYSTEMS="usb", ATTRS{removable}="removable", GOTO="usb_hid_pm_end"
+ACTION="add", SUBSYSTEM="usb", SUBSYSTEMS="usb", ATTRS{removable}="unknown", GOTO="usb_hid_pm_end"
+
ACTION="add", SUBSYSTEM="usb", ATTR{bInterfaceClass}="03", ATTRS{removable}="fixed", TEST="../power/control", ATTR{../power/control}="auto"
+
+LABEL="usb_add_pm_end"
\ No newline at end of file
--
1.7.10.2
reply other threads:[~2012-05-25 12:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337947318-10412-1-git-send-email-mjg@redhat.com \
--to=mjg@redhat.com \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).