From: Frank Crawford <frank@crawford.emu.id.au>
To: Guenter Roeck <linux@roeck-us.net>, Jean Delvare <jdelvare@suse.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v2 3/4] hwmon (it87): Test for chipset before entering configuration mode
Date: Sat, 27 Apr 2024 21:53:43 +1000 [thread overview]
Message-ID: <0886c52480f15d3b9754d43642c722fcd9b6e722.camel@crawford.emu.id.au> (raw)
In-Reply-To: <8d9c9f7d-8a6a-488d-814b-807060aa8336@roeck-us.net>
On Sat, 2024-04-27 at 04:11 -0700, Guenter Roeck wrote:
> On 4/27/24 01:33, Frank Crawford wrote:
...
> > @@ -3144,7 +3186,7 @@ static int __init it87_find(int sioaddr,
> > unsigned short *address,
> > }
> >
> > exit:
> > - superio_exit(sioaddr, config ? has_noconf(config) : false);
> > + superio_exit(sioaddr, opened && config && has_noconf(config));
>
> If 'opened' is false, this could be an affected chip. Are you sure
> that it makes sense to pass 'false' as parameter here in that case ?
> Doesn't that mean that the chip might be one of the affected chips,
> but the superio exit sequence would be executed anyway ?
> Am I missing something ?
Ohh, you may be right, I think I have got myself confused here with
opened and how it is used in superio_exit.
I think it should be !opened, but I will just check I still haven't
messed it up.
>
> Guenter
Thanks
Frank
next prev parent reply other threads:[~2024-04-27 11:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-27 8:33 [PATCH v2 0/4] hwmon (it87): Correct handling for configuration mode Frank Crawford
2024-04-27 8:33 ` [PATCH v2 1/4] hwmon (it87): Rename FEAT_CONF_NOEXIT to FEAT_NOCONF as more descriptive of requirement Frank Crawford
2024-04-27 8:33 ` [PATCH v2 2/4] hwmon (it87): Do not enter configuration mode for some chiptypes Frank Crawford
2024-04-27 8:33 ` [PATCH v2 3/4] hwmon (it87): Test for chipset before entering configuration mode Frank Crawford
2024-04-27 11:11 ` Guenter Roeck
2024-04-27 11:53 ` Frank Crawford [this message]
2024-04-27 17:00 ` Guenter Roeck
2024-04-28 4:31 ` Frank Crawford
2024-04-28 7:03 ` Guenter Roeck
2024-04-28 7:35 ` Frank Crawford
2024-04-27 8:33 ` [PATCH v2 4/4] hwmon (it87): Remove tests nolonger required Frank Crawford
2024-04-27 9:58 ` [PATCH v2 0/4] hwmon (it87): Correct handling for configuration mode Frank Crawford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0886c52480f15d3b9754d43642c722fcd9b6e722.camel@crawford.emu.id.au \
--to=frank@crawford.emu.id.au \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).