From: <marius.cristea@microchip.com>
To: <jic23@kernel.org>, <lars@metafoo.de>, <robh+dt@kernel.org>,
<jdelvare@suse.com>, <linux@roeck-us.net>,
<linux-hwmon@vger.kernel.org>
Cc: <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <marius.cristea@microchip.com>
Subject: [PATCH v5 0/2] adding support for Microchip PAC193X Power Monitor
Date: Thu, 22 Feb 2024 18:42:04 +0200 [thread overview]
Message-ID: <20240222164206.65700-1-marius.cristea@microchip.com> (raw)
From: Marius Cristea <marius.cristea@microchip.com>
Adding support for Microchip PAC193X series of Power Monitor with
Accumulator chip family. This driver covers the following part numbers:
- PAC1931, PAC1932, PAC1933 and PAC1934
This device is at the boundary between IIO and HWMON (if you are
looking just at the "shunt resistors, vsense, power, energy"). The
device also has ADC internally that can measure voltages (up to 4
channels) and also currents (up to 4 channels). The current is measured as
voltage across the shunt_resistor.
I have started with a simple driver (this one that is more appropriate to be
a HWMON) and willing to add more functionality later (like data buffering that
is quite important for example if someone wants to profile power consumption
of the processor itself, or a peripheral device, or a battery, this kind of
functionality was requested by our customers).
The above statement it's a left over comment / attempt to summarize the
discussion of whether IIO or HWMON was a better home for a driver for this
device. Based on current feature set that's not an obvious decision, but there
are other planned features that fit better in IIO.
Differences related to previous patch:
v5:
- fix review comments:
- remove | from device tree binding (not needed because there is no
formatting to preserve).
- update in_shunt_resistor_X attribute to in_shunt_resistorX
- use channel enable to reset the energy counter for each acctive channels
- update values of IIO elements to be in naturally aligned power of 2
- use address in the attribute (IIO_DEVICE_ATTR) to extract address field
- update the code to use mod_delayed_work
- change from kfree to ACPI_FREE
- fix "0-day" issue related to double counter increment
- check functions return in case of errors (like devm_kzalloc that could fail)
- fix coding style issues
v4:
- remove the "reset_accumulators" proprietary attribute
- add enable/disable for energy channels
- remove "reset_accumulators" attribute
- remove unused/redundant defines
- rename variable to be more relevant into a certain context
- make "storagebits" naturally aligned power of 2
- fix coding style issues
- use to_iio_dev_attr to access address field in the IIO_DEVICE_ATTR()
- remove unnecesarry "break" from switch case
- remove double increment and initialization of a variable
- use address as index in IIO_DEVICE_ATTR
- properly handle memory allocation failure
v3:
- this version was sent also to HWMON list
- fix review comments:
- drop redundant description from device tree bindings
- reorder "patternProperties:" to follow "properties:" in device tree bindings
- update comments to proper describe code
- use numbers instead of defines for clarity in some part of the code
- use the new "guard(mutex)"
- use "clamp()" instead of duplicating code
- remove extra layer of checking in some switch cases
- use "i2c_get_match_data()"
- replace while with for loops for the code to look cleaner
- reverse the logic to reduce indent.
- add comment related to channels numbering
- remove memory duplicate when creating dynamic channels
- add "devm_add_action_or_reset" to handle the "cancel_delayed_work_sync"
- remove "pac1934_remove()" function
v2:
- fix review comments:
- change the device tree bindings
- use label property
- fix coding style issues
- remove unused headers
- use get_unaligned_bexx instead of own functions
- change to use a system work queue
- use probe_new instead of old probe
v1:
- first version committed to review
Marius Cristea (2):
dt-bindings: iio: adc: adding support for PAC193X
iio: adc: adding support for PAC193x
.../ABI/testing/sysfs-bus-iio-adc-pac1934 | 9 +
.../bindings/iio/adc/microchip,pac1934.yaml | 120 ++
MAINTAINERS | 7 +
drivers/iio/adc/Kconfig | 11 +
drivers/iio/adc/Makefile | 1 +
drivers/iio/adc/pac1934.c | 1637 +++++++++++++++++
6 files changed, 1785 insertions(+)
create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-adc-pac1934
create mode 100644 Documentation/devicetree/bindings/iio/adc/microchip,pac1934.yaml
create mode 100644 drivers/iio/adc/pac1934.c
base-commit: b1a1eaf6183697b77f7243780a25f35c7c0c8bdf
--
2.34.1
next reply other threads:[~2024-02-22 16:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 16:42 marius.cristea [this message]
2024-02-22 16:42 ` [PATCH v5 1/2] dt-bindings: iio: adc: adding support for PAC193X marius.cristea
2024-02-22 17:45 ` Rob Herring
2024-02-24 7:34 ` kernel test robot
2024-02-24 19:14 ` Jonathan Cameron
2024-02-22 16:42 ` [PATCH v5 2/2] iio: adc: adding support for PAC193x marius.cristea
2024-02-24 19:15 ` Jonathan Cameron
2024-04-05 12:41 ` Conor Dooley
2024-04-05 12:53 ` Marius.Cristea
2024-04-05 16:14 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240222164206.65700-1-marius.cristea@microchip.com \
--to=marius.cristea@microchip.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).