From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <jdelvare@suse.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: add common properties with label
Date: Sat, 24 Feb 2024 10:24:08 +0100 [thread overview]
Message-ID: <2c01f334-d061-44f4-a77d-8714226ff11a@linaro.org> (raw)
In-Reply-To: <20240222195005.GA3735196-robh@kernel.org>
On 22/02/2024 20:50, Rob Herring wrote:
> On Sat, Feb 17, 2024 at 09:21:46AM +0100, Krzysztof Kozlowski wrote:
>> On 16/02/2024 18:11, Guenter Roeck wrote:
>>> On 2/15/24 23:55, Krzysztof Kozlowski wrote:
>>>> Linux hwmon core code parses "label" property for each device, so add a
>>>> common schema for that.
>>>>
>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>
>>> From hwmon perspective:
>>>
>>> Acked-by: Guenter Roeck <linux@roeck-us.net>
>>>
>>>> ---
>>>> .../devicetree/bindings/hwmon/hwmon-common.yaml | 16 ++++++++++++++++
>>>> 1 file changed, 16 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/hwmon/hwmon-common.yaml b/Documentation/devicetree/bindings/hwmon/hwmon-common.yaml
>>>> new file mode 100644
>>>> index 000000000000..d83f4180f622
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/hwmon/hwmon-common.yaml
>>>> @@ -0,0 +1,16 @@
>>>> +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
>>>> +%YAML 1.2
>>>> +---
>>>> +$id: http://devicetree.org/schemas/hwmon/hwmon-common.yaml#
>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>> +
>>>> +title: Hardware Monitoring Devices Common Properties
>>>> +
>>>> +maintainers:
>>>> + - Guenter Roeck <linux@roeck-us.net>
>>>> +
>>>> +properties:
>>>> + label:
>>>> + description: A descriptive name for this device.
>>>> +
>>>
>>> Would it make sense to also add shunt-resistor-micro-ohms ?
>>
>> It's not present on many devices, I think, so it is also not parsed by
>> hwmon core. I plan to add above $ref to hwmon-common to each hwmon
>> binding, so this would mean all of them will get shunt-resistor. I would
>> not add it, but I also don't mind if I am overruled.
>
> I count 11 users. That's enough for me to add it here.
>
> I care less if a device uses a defined property it doesn't need. I'm
> more worried about having any undefined property allowed.
Ack, I'll send a v2.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-02-24 9:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 7:55 [PATCH 0/2] dt-bindings: hwmon: common schema Krzysztof Kozlowski
2024-02-16 7:55 ` [PATCH 1/2] dt-bindings: hwmon: add common properties with label Krzysztof Kozlowski
2024-02-16 17:11 ` Guenter Roeck
2024-02-17 8:21 ` Krzysztof Kozlowski
2024-02-17 15:30 ` Guenter Roeck
2024-02-22 19:50 ` Rob Herring
2024-02-24 9:24 ` Krzysztof Kozlowski [this message]
2024-02-16 7:55 ` [PATCH 2/2] dt-bindings: hwmon: ti,ina2xx: use common hwmon schema Krzysztof Kozlowski
2024-02-16 17:12 ` Guenter Roeck
2024-02-22 19:53 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c01f334-d061-44f4-a77d-8714226ff11a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).