From: Peter Korsgaard <peter@korsgaard.com>
To: Rob Herring <robh@kernel.org>
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
Guenter Roeck <linux@roeck-us.net>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: hwmon: pwm-fan: Document default-pwm property
Date: Thu, 25 Apr 2024 22:21:18 +0200 [thread overview]
Message-ID: <3aa21a01-c994-4b36-8893-181e55a60c5e@korsgaard.com> (raw)
In-Reply-To: <20240425161836.GA2779509-robh@kernel.org>
On 4/25/24 18:18, Rob Herring wrote:
> On Wed, Apr 24, 2024 at 10:24:47PM +0200, Peter Korsgaard wrote:
>> Similar to target-rpm from fan-common.yaml but for the default PWM setting
>> (0..255).
>>
>> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
>> ---
>> Changes since v1:
>> - Rename to default-pwm
>>
>> Documentation/devicetree/bindings/hwmon/pwm-fan.yaml | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml b/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
>> index 4e5abf7580cc..70f062b30985 100644
>> --- a/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
>> +++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
>> @@ -46,6 +46,14 @@ properties:
>>
>> "#cooling-cells": true
>>
>> + default-pwm:
>> + description:
>> + The default fan PWM to use.
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + minimum: 0
>> + maximum: 255
>> + default: 255
>
> See my comments on v1. Please give time for other reviewers a chance to
> comment.
Sorry. As far as I can see, Guenter explained why we cannot generically
translate between a default PWM value and RPM.
Do you still want to move this default-pwm property to fan-common.yaml?
If so, I can send a v3 doing that.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2024-04-25 20:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 20:24 [PATCH v2 1/2] dt-bindings: hwmon: pwm-fan: Document default-pwm property Peter Korsgaard
2024-04-24 20:24 ` [PATCH v2 2/2] hwmon: (pwm-fan): support default-pwm property to set default PWM value Peter Korsgaard
2024-04-25 16:18 ` [PATCH v2 1/2] dt-bindings: hwmon: pwm-fan: Document default-pwm property Rob Herring
2024-04-25 20:21 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3aa21a01-c994-4b36-8893-181e55a60c5e@korsgaard.com \
--to=peter@korsgaard.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).