From: Guenter Roeck <linux@roeck-us.net>
To: Lars Petter Mostad <larspm@gmail.com>
Cc: linux-hwmon@vger.kernel.org,
Lars Petter Mostad <lars.petter.mostad@appear.net>
Subject: Re: [PATCH v2] hwmon: (emc1403) Add support for EMC1428 and EMC1438.
Date: Wed, 8 May 2024 12:21:01 -0700 [thread overview]
Message-ID: <3d097b41-d5a0-4717-acf2-1d1152212d96@roeck-us.net> (raw)
In-Reply-To: <20240508131837.684391-1-lars.petter.mostad@appear.net>
On Wed, May 08, 2024 at 03:18:37PM +0200, Lars Petter Mostad wrote:
> EMC1428 and EMC1438 are similar to EMC14xx, but have eight temperature
> channels, as well as signed data and limit registers. Chips currently
> supported by this driver have unsigned registers only.
>
> Signed-off-by: Lars Petter Mostad <lars.petter.mostad@appear.net>
checkpatch says:
WARNING: From:/Signed-off-by: email address mismatch: 'From: Lars Petter Mostad <larspm@gmail.com>' != 'Signed-off-by: Lars Petter Mostad <lars.petter.mostad@appear.net>'
Both have to be the same. Either consistently use the gmail address,
or (assuming you use gmail to send your e-mails) set up gmail to accept
lars.petter.mostad@appear.net as From address.
> ---
> drivers/hwmon/emc1403.c | 121 ++++++++++++++++++++++++++++++++++++----
Please also update Documentation/hwmon/emc1403.rst.
Other than that, looks good. The changes pass my module test for all chips,
so I don't expect any problems. Please submit v2 with above changes.
Thanks,
Guenter
prev parent reply other threads:[~2024-05-08 19:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 13:18 [PATCH v2] hwmon: (emc1403) Add support for EMC1428 and EMC1438 Lars Petter Mostad
2024-05-08 13:29 ` Lars Petter Mostad
2024-05-08 19:21 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d097b41-d5a0-4717-acf2-1d1152212d96@roeck-us.net \
--to=linux@roeck-us.net \
--cc=lars.petter.mostad@appear.net \
--cc=larspm@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).