From: Guenter Roeck <linux@roeck-us.net>
To: Aleksa Savic <savicaleksa83@gmail.com>, linux-hwmon@vger.kernel.org
Cc: Jack Doan <me@jackdoan.com>, Jean Delvare <jdelvare@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (aquacomputer_d5next) Set fan to direct PWM mode when writing value
Date: Sat, 17 Feb 2024 10:24:50 -0800 [thread overview]
Message-ID: <718f0dd9-121a-4885-8976-aaafa7c44f2d@roeck-us.net> (raw)
In-Reply-To: <20240217181536.344386-1-savicaleksa83@gmail.com>
On 2/17/24 10:15, Aleksa Savic wrote:
> When setting a PWM value for a fan channel, ensure that the device
> is actually in direct PWM value mode, as it could be in PID, curve or
> fan following mode from previous user configurations. The byte
> signifying the channel mode is just behind the offset for the value.
> Otherwise, setting PWM speed might result in a no-op from the point
> of the user.
>
You can require that a device is in manual mode when setting pwm
modes, and return an error if it isn't. However, changing the mode
to manual automatically when a pwm value is written is not acceptable.
Guenter
next prev parent reply other threads:[~2024-02-17 18:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-17 18:15 [PATCH] hwmon: (aquacomputer_d5next) Set fan to direct PWM mode when writing value Aleksa Savic
2024-02-17 18:24 ` Guenter Roeck [this message]
2024-02-18 16:02 ` Aleksa Savic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=718f0dd9-121a-4885-8976-aaafa7c44f2d@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@jackdoan.com \
--cc=savicaleksa83@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).