From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To: "jdelvare@suse.com" <jdelvare@suse.com>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"robh@kernel.org" <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>
Cc: "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] hwmon: (adt7475) Add support for configuring initial PWM duty cycle
Date: Wed, 8 May 2024 17:49:49 +0000 [thread overview]
Message-ID: <7cb45e90-659e-4caa-8e10-be52e1c969c6@alliedtelesis.co.nz> (raw)
In-Reply-To: <20240508170544.263059-3-chris.packham@alliedtelesis.co.nz>
On 9/05/24 05:05, Chris Packham wrote:
> By default the PWM duty cycle in hardware is 100%. On some systems this
> can cause unwanted fan noise. Add the ability to take an initial PWM
> duty cycle and frequency via device properties.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
> drivers/hwmon/adt7475.c | 56 +++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 56 insertions(+)
>
> diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c
> index 4224ffb30483..b0c7c1a95897 100644
> --- a/drivers/hwmon/adt7475.c
> +++ b/drivers/hwmon/adt7475.c
> @@ -1662,6 +1662,54 @@ static int adt7475_set_pwm_polarity(struct i2c_client *client)
> return 0;
> }
>
> +static int adt7475_set_pwm_initial_freq(struct i2c_client *client)
> +{
> + int ret, out, i;
> + u32 freqs[ADT7475_PWM_COUNT];
> + int data;
> +
> + ret = device_property_read_u32_array(&client->dev,
> + "pwm-initial-frequency", freqs,
> + ARRAY_SIZE(freqs));
> + if (ret)
> + return ret;
> +
> + for (i = 0; i < ADT7475_PWM_COUNT; i++) {
> + out = find_closest(freqs[i], pwmfreq_table, ARRAY_SIZE(pwmfreq_table));
> + data = adt7475_read(TEMP_TRANGE_REG(i));
> + if (data < 0)
> + return data;
> + data &= ~0xf;
> + data |= out;
> +
> + ret = i2c_smbus_write_byte_data(client, TEMP_TRANGE_REG(i), data);
> + if (ret)
> + return ret;
> + }
> +
> + return 0;
> +}
> +
> +static int adt7475_set_pwm_initial_duty(struct i2c_client *client)
> +{
> + int ret, i;
> + u32 dutys[ADT7475_PWM_COUNT];
> +
> + ret = device_property_read_u32_array(&client->dev,
> + "adi,pwm-initial-duty-cycle", dutys,
> + ARRAY_SIZE(dutys));
> + if (ret)
> + return ret;
> +
> + for (i = 0; i < ADT7475_PWM_COUNT; i++) {
> + ret = i2c_smbus_write_byte_data(client, PWM_MAX_REG(i), dutys[i] & 0xff);
> + if (ret)
> + return ret;
> + }
> +
> + return 0;
> +}
> +
> static int adt7475_probe(struct i2c_client *client)
> {
> enum chips chip;
> @@ -1778,6 +1826,14 @@ static int adt7475_probe(struct i2c_client *client)
> if (ret && ret != -EINVAL)
> dev_warn(&client->dev, "Error configuring pwm polarity\n");
>
> + ret = adt7475_set_pwm_initial_freq(client);
> + if (ret)
> + return ret;
Whoops I meant to send the version that handles -EINVAL. v2 will handle
errors the same way as pwm_polarity above. I'll wait for a bit before
sending that out.
> +
> + ret = adt7475_set_pwm_initial_duty(client);
> + if (ret)
> + return ret;
> +
> /* Start monitoring */
> switch (chip) {
> case adt7475:
prev parent reply other threads:[~2024-05-08 17:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 17:05 [PATCH 0/2] hwmon: (adt7475) duty cycle configuration Chris Packham
2024-05-08 17:05 ` [PATCH 1/2] dt-bindings: hwmon: Document adt7475 PWM initial duty cycle Chris Packham
2024-05-08 19:00 ` Rob Herring (Arm)
2024-05-08 17:05 ` [PATCH 2/2] hwmon: (adt7475) Add support for configuring initial PWM " Chris Packham
2024-05-08 17:49 ` Chris Packham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cb45e90-659e-4caa-8e10-be52e1c969c6@alliedtelesis.co.nz \
--to=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).