From: Zev Weiss <zev@bewilderbeest.net>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Hardware Monitoring <linux-hwmon@vger.kernel.org>,
Conor Dooley <conor@kernel.org>,
Naresh Solanki <naresh.solanki@9elements.com>
Subject: Re: [PATCH 2/3] hwmon: (pmbus/lm25066) Use PMBUS_REGULATOR_ONE to declare regulator
Date: Wed, 14 Feb 2024 17:04:24 -0800 [thread overview]
Message-ID: <8669f426-38a6-4ea8-ae4b-0d29c1d09a29@hatter.bewilderbeest.net> (raw)
In-Reply-To: <20240214194342.3678254-3-linux@roeck-us.net>
On Wed, Feb 14, 2024 at 11:43:41AM PST, Guenter Roeck wrote:
>If a chip only provides a single regulator, it should be named 'vout'
>and not 'vout0'. Declare regulator using PMBUS_REGULATOR_ONE() to make
>that happen.
>
Hi Guenter,
This will necessitate a DTS update on at least one platform to maintain
compatibility (Delta ahe50dc BMC, [1]). I'm not sure offhand if there
are process/policy rules about mixing code changes and device-tree
changes in the same commit, but changing either one without the other
would break things.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/aspeed/aspeed-bmc-delta-ahe50dc.dts?id=8d3dea210042f54b952b481838c1e7dfc4ec751d#n21
Thanks,
Zev
next prev parent reply other threads:[~2024-02-15 1:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 19:43 [PATCH 0/3] hwmon: (pmbus) Use PMBUS_REGULATOR_ONE to declare regulators with single output Guenter Roeck
2024-02-14 19:43 ` [PATCH 1/3] hwmon: (pmbus/tda38640) Use PMBUS_REGULATOR_ONE to declare regulator Guenter Roeck
2024-02-14 19:43 ` [PATCH 2/3] hwmon: (pmbus/lm25066) " Guenter Roeck
2024-02-15 1:04 ` Zev Weiss [this message]
2024-02-15 1:22 ` Guenter Roeck
2024-02-15 10:14 ` Zev Weiss
2024-02-15 12:33 ` Conor Dooley
2024-02-14 19:43 ` [PATCH 3/3] hwmon: (pmbus/ir38064) " Guenter Roeck
2024-02-17 22:00 ` [PATCH 0/3] hwmon: (pmbus) Use PMBUS_REGULATOR_ONE to declare regulators with single output Conor Dooley
2024-02-19 14:48 ` Conor Dooley
2024-02-19 15:13 ` Guenter Roeck
2024-02-21 19:06 ` Conor Dooley
2024-02-22 1:10 ` Zev Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8669f426-38a6-4ea8-ae4b-0d29c1d09a29@hatter.bewilderbeest.net \
--to=zev@bewilderbeest.net \
--cc=conor@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=naresh.solanki@9elements.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).