From: Inochi Amaoto <inochiama@outlook.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Inochi Amaoto <inochiama@outlook.com>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Chen Wang <unicorn_wang@outlook.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v4 1/2] dt-bindings: hwmon: Add Sophgo SG2042 external hardware monitor support
Date: Fri, 3 May 2024 20:13:01 +0800 [thread overview]
Message-ID: <IA1PR20MB49535CF3617665EC8370F2E0BB1F2@IA1PR20MB4953.namprd20.prod.outlook.com> (raw)
In-Reply-To: <cdad08fd-1162-471a-b060-d560f38e50f6@kernel.org>
On Fri, May 03, 2024 at 09:09:30AM GMT, Krzysztof Kozlowski wrote:
> On 03/05/2024 04:20, Inochi Amaoto wrote:
> > Due to the design, Sophgo SG2042 use an external MCU to provide
> > hardware information, thermal information and reset control.
> >
> > Add bindings for this monitor device.
>
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - "#thermal-sensor-cells"
> > +
> > +allOf:
> > + - $ref: ../thermal/thermal-sensor.yaml#
>
> Where did you find such path? Please use full path instead, so
> /schemas/thermal.....
Thanks. I will change it.
>
> > +
> > +additionalProperties: false
>
> unevaluatedProperties: false instead (even though currently it does not
> matter).
>
Thanks, I have checked json schema doc, using "unevaluatedProperties"
is more suitable.
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2024-05-03 12:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 2:19 [PATCH v4 0/2] riscv: sophgo: Add SG2042 external hardware monitor support Inochi Amaoto
2024-05-03 2:20 ` [PATCH v4 1/2] dt-bindings: hwmon: Add Sophgo " Inochi Amaoto
2024-05-03 7:09 ` Krzysztof Kozlowski
2024-05-03 12:13 ` Inochi Amaoto [this message]
2024-05-03 2:20 ` [PATCH v4 2/2] drivers: hwmon: sophgo: Add " Inochi Amaoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=IA1PR20MB49535CF3617665EC8370F2E0BB1F2@IA1PR20MB4953.namprd20.prod.outlook.com \
--to=inochiama@outlook.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).