From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Chanh Nguyen <chanh@amperemail.onmicrosoft.com>,
Guenter Roeck <linux@roeck-us.net>,
Conor Dooley <conor@kernel.org>
Cc: Chanh Nguyen <chanh@os.amperecomputing.com>,
Jean Delvare <jdelvare@suse.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Justin Ledford <justinledford@google.com>,
devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Open Source Submission <patches@amperecomputing.com>,
Phong Vo <phong@os.amperecomputing.com>,
Thang Nguyen <thang@os.amperecomputing.com>,
Quan Nguyen <quan@os.amperecomputing.com>
Subject: Re: [PATCH v2 3/3] dt-bindings: hwmon: max31790: Add maxim,pwmout-pin-as-tach-input property
Date: Thu, 9 May 2024 10:29:31 +0200 [thread overview]
Message-ID: <a20479be-a4cf-4fb5-8d37-277d14a93224@linaro.org> (raw)
In-Reply-To: <8fb38eb3-bb94-49cc-b5bc-80989d7876b9@amperemail.onmicrosoft.com>
On 08/05/2024 05:44, Chanh Nguyen wrote:
>>>>>
>>>>
>>>> I am not even sure how to define tach-ch to mean "use the pwm output pin
>>>> associated with this tachometer input channel not as pwm output
>>>> but as tachometer input". That would be a boolean, not a number.
>>>>
>>>
>>> Thank Guenter,
>>>
>>> I reviewed again the "tach-ch" property, which is used in the
>>> https://elixir.bootlin.com/linux/v6.9-rc6/source/Documentation/devicetree/bindings/hwmon/aspeed,g6-pwm-tach.yaml#L68 and https://elixir.bootlin.com/linux/v6.9-rc6/source/drivers/hwmon/aspeed-g6-pwm-tach.c#L434
>>>
>>> That is something completely different from my purpose.
>>>
>>
>> Based on its definition, tach-ch is associated with fans, and it looks
>> like the .yaml file groups multiple sets of fans into a single
>> fan node.
>>
>> In the simple case that would be
>> tach-ch = <1>
>> ...
>> tach-ch = <12>
>>
>> or, if all fans are controlled by a single pwm
>> tach-ch = <1 2 3 4 5 6 8 9 10 11 12>
>>
>> The existence of tachometer channel 7..12 implies that pwm channel
>> (tachometer
>> channel - 6) is used as tachometer channel. That should be sufficient to
>> program
>> the chip for that channel. All you'd have to do is to ensure that pwm
>> channel
>> "X" is not listed as tachometer channel "X + 6", and program pwm channel
>> "X - 6"
>> for tachometer channels 7..12 as tachometer channels.
>>
>
> Hi Guenter,
>
> I applied the patch [2/3] in my patch series
> (https://lore.kernel.org/lkml/20240414042246.8681-3-chanh@os.amperecomputing.com/)
>
> My device tree is configured as below, I would like to configure PWMOUT
> pins 5 and 6 to become the tachometer input pins.
>
And what is wrong in described common tach-ch property? I think we
explained it three times and you did not provide any arguments, what's
missing. Instead you say "I want something like this in DTS" which is
not an argument and does not help discussion.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-05-09 8:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-14 4:22 [PATCH v2 0/3] Update the max31790 driver Chanh Nguyen
2024-04-14 4:22 ` [PATCH v2 1/3] dt-bindings: hwmon: Add maxim max31790 bindings Chanh Nguyen
2024-04-14 6:03 ` Krzysztof Kozlowski
2024-04-16 4:38 ` Chanh Nguyen
2024-04-14 4:22 ` [PATCH v2 2/3] hwmon: (max31790): Support config PWM output becomes TACH Chanh Nguyen
2024-04-14 8:03 ` Christophe JAILLET
2024-04-16 5:27 ` Chanh Nguyen
2024-04-16 17:39 ` Christophe JAILLET
2024-04-17 2:54 ` Chanh Nguyen
2024-04-14 4:22 ` [PATCH v2 3/3] dt-bindings: hwmon: max31790: Add maxim,pwmout-pin-as-tach-input property Chanh Nguyen
2024-04-14 6:07 ` Krzysztof Kozlowski
2024-04-16 4:52 ` Chanh Nguyen
2024-04-23 8:45 ` Chanh Nguyen
2024-04-23 17:02 ` Conor Dooley
2024-04-25 10:33 ` Chanh Nguyen
2024-04-25 14:05 ` Guenter Roeck
2024-04-25 15:46 ` Krzysztof Kozlowski
2024-04-25 15:56 ` Conor Dooley
2024-05-05 10:08 ` Chanh Nguyen
2024-05-05 15:40 ` Guenter Roeck
2024-05-08 3:44 ` Chanh Nguyen
2024-05-08 16:47 ` Conor Dooley
2024-05-09 8:29 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a20479be-a4cf-4fb5-8d37-277d14a93224@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=chanh@amperemail.onmicrosoft.com \
--cc=chanh@os.amperecomputing.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=justinledford@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=openbmc@lists.ozlabs.org \
--cc=patches@amperecomputing.com \
--cc=phong@os.amperecomputing.com \
--cc=quan@os.amperecomputing.com \
--cc=robh+dt@kernel.org \
--cc=thang@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).