From: Guenter Roeck <linux@roeck-us.net>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Jean Delvare" <jdelvare@suse.com>,
"Joel Stanley" <joel@jms.id.au>
Cc: Andrew Jeffery <andrew@codeconstruct.com.au>,
linux-hwmon@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-pwm@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH 2/2] hwmon: (aspeed-g6-pwm-tacho): Make use of devm_pwmchip_alloc() function
Date: Mon, 18 Mar 2024 09:45:34 -0700 [thread overview]
Message-ID: <b07680fe-969a-49aa-9995-aa51261f1bee@roeck-us.net> (raw)
In-Reply-To: <e95e41eea5a138ae206c9116ba3cb1d9e0178284.1710777536.git.u.kleine-koenig@pengutronix.de>
On 3/18/24 09:09, Uwe Kleine-König wrote:
> This prepares the aspeed-g6-pwm-tacho driver to further changes of the
> pwm core outlined in the commit introducing devm_pwmchip_alloc(). There
> is no intended semantical change and the driver should behave as before.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/hwmon/aspeed-g6-pwm-tach.c | 15 +++++++++------
> 1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/hwmon/aspeed-g6-pwm-tach.c b/drivers/hwmon/aspeed-g6-pwm-tach.c
> index 64def5e4cdf6..332c02216668 100644
> --- a/drivers/hwmon/aspeed-g6-pwm-tach.c
> +++ b/drivers/hwmon/aspeed-g6-pwm-tach.c
> @@ -136,7 +136,6 @@ struct aspeed_pwm_tach_data {
> struct clk *clk;
> struct reset_control *reset;
> unsigned long clk_rate;
> - struct pwm_chip chip;
> bool tach_present[TACH_ASPEED_NR_TACHS];
> u32 tach_divisor;
> };
> @@ -144,7 +143,7 @@ struct aspeed_pwm_tach_data {
> static inline struct aspeed_pwm_tach_data *
> aspeed_pwm_chip_to_data(struct pwm_chip *chip)
> {
> - return container_of(chip, struct aspeed_pwm_tach_data, chip);
> + return pwmchip_get_drvdata(chip);
> }
>
> static int aspeed_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm,
> @@ -459,6 +458,7 @@ static int aspeed_pwm_tach_probe(struct platform_device *pdev)
> int ret;
> struct device_node *child;
> struct aspeed_pwm_tach_data *priv;
> + struct pwm_chip *chip;
>
> priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> if (!priv)
> @@ -487,11 +487,14 @@ static int aspeed_pwm_tach_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> - priv->chip.dev = dev;
> - priv->chip.ops = &aspeed_pwm_ops;
> - priv->chip.npwm = PWM_ASPEED_NR_PWMS;
> + chip = devm_pwmchip_alloc(dev, PWM_ASPEED_NR_PWMS, 0);
> + if (IS_ERR(chip))
> + return PTR_ERR(chip);
>
> - ret = devm_pwmchip_add(dev, &priv->chip);
> + pwmchip_set_drvdata(chip, priv);
> + chip->ops = &aspeed_pwm_ops;
> +
> + ret = devm_pwmchip_add(dev, chip);
> if (ret)
> return dev_err_probe(dev, ret, "Failed to add PWM chip\n");
>
next prev parent reply other threads:[~2024-03-18 16:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 16:09 [PATCH 0/2] hwmon: (aspeed-g6-pwm-tacho): Prepare for further pwm core changes Uwe Kleine-König
2024-03-18 16:09 ` [PATCH 1/2] hwmon: (aspeed-g6-pwm-tacho): Make use of pwmchip_parent() accessor Uwe Kleine-König
2024-03-18 16:44 ` Guenter Roeck
2024-03-18 16:09 ` [PATCH 2/2] hwmon: (aspeed-g6-pwm-tacho): Make use of devm_pwmchip_alloc() function Uwe Kleine-König
2024-03-18 16:45 ` Guenter Roeck [this message]
2024-04-13 8:33 ` [PATCH 0/2] hwmon: (aspeed-g6-pwm-tacho): Prepare for further pwm core changes Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b07680fe-969a-49aa-9995-aa51261f1bee@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andrew@codeconstruct.com.au \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).