From: Guenter Roeck <linux@roeck-us.net>
To: Erhard Furtner <erhard_f@mailbox.org>
Cc: Hardware Monitoring <linux-hwmon@vger.kernel.org>,
Jean Delvare <jdelvare@suse.com>,
Ahmad Khalifa <ahmad@khalifa.ws>
Subject: Re: [PATCH] nct6775: Fix access to temperature configuration registers
Date: Wed, 21 Feb 2024 15:39:44 -0800 [thread overview]
Message-ID: <c1f83998-d7c0-4e37-85c9-e5e0e97e1595@roeck-us.net> (raw)
In-Reply-To: <20240221235335.136d61e9@yea>
Hi Erhard,
On 2/21/24 14:53, Erhard Furtner wrote:
> On Wed, 21 Feb 2024 06:13:45 -0800
> Guenter Roeck <linux@roeck-us.net> wrote:
>
>> The number of temperature configuration registers does
>> not always match the total number of temperature registers.
>> This can result in access errors reported if KASAN is enabled.
>>
>> BUG: KASAN: global-out-of-bounds in nct6775_probe+0x5654/0x6fe9 nct6775_core
>>
>> Reported-by: Erhard Furtner <erhard_f@mailbox.org>
>> Closes: https://lore.kernel.org/linux-hwmon/d51181d1-d26b-42b2-b002-3f5a4037721f@roeck-us.net/
>> Fixes: 578ab5f0e4b1 ("hwmon: (nct6775) Add support for NCT6791D")
>> Fixes: b7f1f7b2523a ("hwmon: (nct6775) Additional TEMP registers for nct6799")
>> Cc: Ahmad Khalifa <ahmad@khalifa.ws>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>> Erhard,
>>
>> it would be great if you can test this patch on your system.
>>
>> Thanks,
>> Guenter
>
> Applied your patch on top of 6.8-rc5 and 6.6.0.
>
> Works fine in both cases, the KASAN hit is gone. Many thanks!
>
Excellent. Thanks a lot for confirming!
Guenter
prev parent reply other threads:[~2024-02-21 23:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 14:13 [PATCH] nct6775: Fix access to temperature configuration registers Guenter Roeck
2024-02-21 21:31 ` Ahmad Khalifa
2024-02-21 21:59 ` Guenter Roeck
2024-02-21 22:12 ` Ahmad Khalifa
2024-02-21 22:22 ` Guenter Roeck
2024-02-21 22:53 ` Erhard Furtner
2024-02-21 23:39 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1f83998-d7c0-4e37-85c9-e5e0e97e1595@roeck-us.net \
--to=linux@roeck-us.net \
--cc=ahmad@khalifa.ws \
--cc=erhard_f@mailbox.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).