From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: hwmon: adc128d818: convert to dtschema
Date: Tue, 19 Mar 2024 06:49:32 +0100 [thread overview]
Message-ID: <de0b32b3-348a-4d42-89cd-df2c439b8009@linaro.org> (raw)
In-Reply-To: <20240318-adc128d818_dtschema-v1-1-d0af2caef145@gmail.com>
On 18/03/2024 21:12, Javier Carrasco wrote:
> Convert adc128d818 bindings to dtschema to support validation.
>
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Thank you for your patch. There is something to discuss/improve.
> +$id: http://devicetree.org/schemas/hwmon/ti,adc128d818.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments ADC128D818 ADC System Monitor With Temperature Sensor
> +
> +maintainers:
> + - Javier Carrasco <javier.carrasco.cruz@gmail.com>
> +
> +description: |
> + The ADC128D818 is a 12-Bit, 8-Channel Analog to Digital Converter (ADC)
> + with a temperature sensor and an I2C interface.
> +
> + Datasheets:
> + https://www.ti.com/product/ADC128D818
> +
> +properties:
> + compatible:
> + const: ti,adc128d818
> +
> + reg:
> + maxItems: 1
> +
> + ti,mode:
You need | to preserve the formatting.
With this:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-19 5:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 20:12 [PATCH] dt-bindings: hwmon: adc128d818: convert to dtschema Javier Carrasco
2024-03-19 5:49 ` Krzysztof Kozlowski [this message]
2024-03-19 7:01 ` Javier Carrasco
2024-03-19 9:28 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de0b32b3-348a-4d42-89cd-df2c439b8009@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).