From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>, Andi Shyti <andi.shyti@kernel.org>,
Lee Jones <lee@kernel.org>, Jiawen Wu <jiawenwu@trustnetic.com>,
Mengyuan Lou <mengyuanlou@net-swift.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Andrew Lunn <andrew@lunn.ch>,
Duanqiang Wen <duanqiangwen@net-swift.com>,
"open list:SYNOPSYS DESIGNWARE I2C DRIVER"
<linux-i2c@vger.kernel.org>,
"open list:WANGXUN ETHERNET DRIVER" <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/4] i2c: designware: Create shared header hosting driver name
Date: Tue, 23 Apr 2024 18:22:15 -0700 [thread overview]
Message-ID: <0aac2975-42d0-4abe-9405-bf8a38a94104@broadcom.com> (raw)
In-Reply-To: <ZihLSKe_BHxasBql@surfacebook.localdomain>
[-- Attachment #1: Type: text/plain, Size: 1112 bytes --]
On 4/23/2024 4:59 PM, Andy Shevchenko wrote:
> Tue, Apr 23, 2024 at 04:36:19PM -0700, Florian Fainelli kirjoitti:
>> We have a number of drivers that reference the string "i2c_designware"
>> yet this is copied all over the places with opportunities for this
>> string being mis-used. Create a shared header that defines this as a
>> constant that other drivers can reference.
>
> ...
>
>> #include <linux/i2c.h>
>> +#include <linux/i2c-designware.h>
>
> Can it be hidden in the subfolder?
That would require the MFD and ethernet drivers to include relative to
where they are in the source tree, do we really want that?
>
> ...
>
>> -#define DRIVER_NAME "i2c-designware-pci"
>> +#define DRIVER_NAME I2C_DESIGNWARE_NAME "-pci"
>
> Oh, this makes all the things hard to read.
OK, besides there is a change for '_' when it was a '-' before, so maybe
I should drop that hunk.
>
>> /* Work with hotplug and coldplug */
>> -MODULE_ALIAS("i2c_designware-pci");
>> +MODULE_ALIAS(DRIVER_NAME);
>
> I believe we shouldn't use MODULE_ALIAS() without real justification.
Pre-existing change.
--
Florian
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]
next prev parent reply other threads:[~2024-04-24 1:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 23:36 [PATCH 0/4] Define i2c_designware in a header file Florian Fainelli
2024-04-23 23:36 ` [PATCH 1/4] i2c: designware: Create shared header hosting driver name Florian Fainelli
2024-04-23 23:59 ` Andy Shevchenko
2024-04-24 1:22 ` Florian Fainelli [this message]
2024-04-24 12:18 ` Andrew Lunn
2024-04-24 12:45 ` Andy Shevchenko
2024-04-25 8:33 ` Jarkko Nikula
2024-04-25 9:20 ` Andy Shevchenko
2024-04-23 23:36 ` [PATCH 2/4] mfd: intel-lpss: Utilize i2c-designware.h Florian Fainelli
2024-04-24 0:00 ` Andy Shevchenko
2024-04-24 3:20 ` Florian Fainelli
2024-05-02 7:17 ` Lee Jones
2024-05-02 16:19 ` Florian Fainelli
2024-05-02 16:42 ` Lee Jones
2024-04-23 23:36 ` [PATCH 3/4] mfd: intel_quark_i2c_gpio: " Florian Fainelli
2024-04-24 0:01 ` Andy Shevchenko
2024-04-24 1:28 ` Florian Fainelli
2024-04-24 12:37 ` Andy Shevchenko
2024-04-24 16:35 ` Florian Fainelli
2024-04-23 23:36 ` [PATCH 4/4] net: txgbe: " Florian Fainelli
2024-04-24 16:14 ` Simon Horman
2024-04-24 16:22 ` Florian Fainelli
2024-04-24 17:34 ` Simon Horman
2024-04-23 23:56 ` [PATCH 0/4] Define i2c_designware in a header file Andy Shevchenko
2024-04-24 1:21 ` Florian Fainelli
2024-04-24 14:26 ` Andy Shevchenko
2024-04-24 16:26 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0aac2975-42d0-4abe-9405-bf8a38a94104@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=andi.shyti@kernel.org \
--cc=andrew@lunn.ch \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=davem@davemloft.net \
--cc=duanqiangwen@net-swift.com \
--cc=edumazet@google.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jiawenwu@trustnetic.com \
--cc=jsd@semihalf.com \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=mengyuanlou@net-swift.com \
--cc=mika.westerberg@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).