From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Farouk Bouabid <farouk.bouabid@theobroma-systems.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Peter Rosin <peda@axentia.se>, Andi Shyti <andi.shyti@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Quentin Schulz <quentin.schulz@theobroma-systems.com>,
Heiko Stuebner <heiko@sntech.de>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 2/7] dt-bindings: i2c: mux: mule: add dt-bindings for mule i2c multiplexer
Date: Mon, 29 Apr 2024 08:27:44 +0200 [thread overview]
Message-ID: <1613d7e3-a5cc-4b8e-a905-3699779476fe@linaro.org> (raw)
In-Reply-To: <20240426-dev-mule-i2c-mux-v1-2-045a482f6ffb@theobroma-systems.com>
Except that this was not fully tested few comments.
A nit, subject: drop second/last, redundant "dt-bindings for". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
On 26/04/2024 18:49, Farouk Bouabid wrote:
> This patch adds support for the Mule I2C multiplexer.
Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
>
> Mule is an mcu that emulates a set of i2c devices which are reacheable
> through an i2c-mux.
>
> The emulated devices share a single i2c address with the mux itself where
> the requested register is what determines which logic is executed (mux or
> device).
>
> Signed-off-by: Farouk Bouabid <farouk.bouabid@theobroma-systems.com>
> ---
> .../devicetree/bindings/i2c/i2c-mux-mule.yaml | 80 ++++++++++++++++++++++
> 1 file changed, 80 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mux-mule.yaml b/Documentation/devicetree/bindings/i2c/i2c-mux-mule.yaml
> new file mode 100644
> index 000000000000..458e4661cbc8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mux-mule.yaml
Use compatible as filename.
> @@ -0,0 +1,80 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i2c/i2c-mux-mule.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mule I2C multiplexer
> +
> +maintainers:
> + - Farouk Bouabid <farouk.bouabid@theobroma-systems.com>
> + - Quentin Schulz <quentin.schulz@theobroma-systems.com>
> +
> +description: |
> + Mule is an mcu that emulates a set of i2c devices which are reacheable
typo, reachable
> + through an i2c-mux.
> +
> + The emulated devices share a single i2c address with the mux itself where
> + the requested register is what determines which logic is executed (mux or
> + device)
> +
> + +--------------------------------------------------+
> + | Mule |
> + | +---------------+ |
> + ------+->|Config register|----+ |
> + | | +---------------+ | |
> + | | V_ |
> + | | | \ +--------+ |
> + | | | \-------->| dev #0 | |
> + | | | | +--------+ |
> + | | | M |-------->| dev #1 | |
> + | +--------------------->| U | +--------+ |
> + | | X |-------->| dev #2 | |
> + | | | +--------+ |
> + | | /-------->| dev #3 | |
> + | |__/ +--------+ |
> + +--------------------------------------------------+
> +
> +
> +allOf:
> + - $ref: /schemas/i2c/i2c-mux.yaml#
> +
> +properties:
> + compatible:
> + const: tsd,mule-i2c-mux
> +
> + reg:
> + maxItems: 1
> +
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-29 6:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 16:49 [PATCH 0/7] Add Mule I2C multiplexer support Farouk Bouabid
2024-04-26 16:49 ` [PATCH 1/7] i2c: mux: add the ability to share mux-address with child nodes Farouk Bouabid
2024-04-29 15:46 ` Peter Rosin
2024-05-02 15:01 ` Farouk Bouabid
2024-05-03 5:30 ` Peter Rosin
2024-05-03 16:20 ` Quentin Schulz
2024-04-26 16:49 ` [PATCH 2/7] dt-bindings: i2c: mux: mule: add dt-bindings for mule i2c multiplexer Farouk Bouabid
2024-04-26 18:22 ` Rob Herring
2024-05-02 12:21 ` Farouk Bouabid
2024-04-29 6:27 ` Krzysztof Kozlowski [this message]
2024-04-29 13:56 ` Rob Herring
2024-05-02 12:14 ` Farouk Bouabid
2024-04-26 16:49 ` [PATCH 3/7] i2c: muxes: add support " Farouk Bouabid
2024-04-29 6:33 ` Krzysztof Kozlowski
2024-05-02 12:31 ` Farouk Bouabid
2024-04-26 16:49 ` [PATCH 4/7] arm64: dts: rockchip: add mule i2c mux (0x18) on rk3399-puma Farouk Bouabid
2024-04-26 16:49 ` [PATCH 5/7] arm64: dts: rockchip: add mule i2c mux (0x18) on rk3588-tiger Farouk Bouabid
2024-04-26 16:49 ` [PATCH 6/7] arm64: dts: rockchip: add mule i2c mux (0x18) on px30-ringneck Farouk Bouabid
2024-04-26 16:49 ` [PATCH 7/7] arm64: dts: rockchip: add mule i2c mux (0x18) on rk3588-jaguar Farouk Bouabid
2024-04-29 14:41 ` [PATCH 0/7] Add Mule I2C multiplexer support Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1613d7e3-a5cc-4b8e-a905-3699779476fe@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=farouk.bouabid@theobroma-systems.com \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=peda@axentia.se \
--cc=quentin.schulz@theobroma-systems.com \
--cc=robh@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).