From: Philipp Stanner <pstanner@redhat.com>
To: "Thomas Richard" <thomas.richard@bootlin.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Andy Shevchenko" <andy@kernel.org>,
"Tony Lindgren" <tony@atomide.com>,
"Haojian Zhuang" <haojian.zhuang@linaro.org>,
"Vignesh R" <vigneshr@ti.com>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Janusz Krzysztofik" <jmkrzyszt@gmail.com>,
"Andi Shyti" <andi.shyti@kernel.org>,
"Peter Rosin" <peda@axentia.se>, "Vinod Koul" <vkoul@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-phy@lists.infradead.org, linux-pci@vger.kernel.org,
gregory.clement@bootlin.com, theo.lebrun@bootlin.com,
thomas.petazzoni@bootlin.com, u-kumar1@ti.com,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v3 00/18] Add suspend to ram support for PCIe on J7200
Date: Thu, 15 Feb 2024 16:40:10 +0100 [thread overview]
Message-ID: <1b2ffe636a19faef87b9c48fee6d17bfb9f1a3bf.camel@redhat.com> (raw)
In-Reply-To: <20240102-j7200-pcie-s2r-v3-0-5c2e4a3fac1f@bootlin.com>
On Thu, 2024-02-15 at 16:17 +0100, Thomas Richard wrote:
> This add suspend to ram support for the PCIe (RC mode) on J7200
> platform.
>
> In RC mode, the reset pin for endpoints is managed by a gpio expander
> on a
> i2c bus. This pin shall be managed in suspend_noirq() and
> resume_noirq().
> The suspend/resume has been moved to suspend_noirq()/resume_noirq()
> for
> pca953x (expander) and pinctrl-single.
>
> To do i2c accesses during suspend_noirq/resume_noirq, we need to
> force the
> wakeup of the i2c controller (which is autosuspended) during suspend
> callback.
> It's the only way to wakeup the controller if it's autosuspended, as
> runtime pm is disabled in suspend_noirq and resume_noirq.
>
> The main change in this v3 is the removal of the probe boolean for
> the
> functions wiz_clock_probe() and cdns_pcie_host_setup().
> Their contents were split in multiple functions which are called in
> the
> resume_noirq() callbacks.
>
> Signed-off-by: Thomas Richard <thomas.richard@bootlin.com>
> ---
> Changes in v3:
> - pinctrl-single: split patch in two parts, a first patch to remove
> the
> dead code, a second to move suspend()/resume() callbacks to noirq.
> - i2c-omap: add a comments above the suspend_noirq() callback.
> - mux: now mux_chip_resume() try to restores all muxes, then return 0
> if
> all is ok or the first failure.
> - mmio: fix commit message.
> - phy-j721e-wiz: add a patch to use dev_err_probe() instead of
> dev_err() in
> the wiz_clock_init() function.
> - phy-j721e-wiz: remove probe boolean for the wiz_clock_init(),
> rename the
> function to wiz_clock_probe(), extract hardware configuration part
> in a
> new function wiz_clock_init().
> - phy-cadence-torrent: use dev_err_probe() and fix commit messages
> - pcie-cadence-host: remove probe boolean for the
> cdns_pcie_host_setup()
> function and extract the link setup part in a new function
> cdns_pcie_host_link_setup().
> - pcie-cadence-host: make cdns_pcie_host_init() global.
> - pci-j721e: use the cdns_pcie_host_link_setup()
> cdns_pcie_host_init()
> functions in the resume_noirq() callback.
> - Link to v2:
> https://lore.kernel.org/r/20240102-j7200-pcie-s2r-v2-0-8e4f7d228ec2@bootlin.com
>
> Changes in v2:
> - all: fix commits messages.
> - all: use DEFINE_NOIRQ_DEV_PM_OPS and pm_sleep_ptr macros.
> - all: remove useless #ifdef CONFIG_PM.
> - pinctrl-single: drop dead code
> - mux: add mux_chip_resume() function in mux core.
> - mmio: resume sequence is now a call to mux_chip_resume().
> - phy-cadence-torrent: fix typo in resume sequence
> (reset_control_assert()
> instead of reset_control_put()).
> - phy-cadence-torrent: use PHY instead of phy.
> - pci-j721e: do not shadow cdns_pcie_host_setup return code in resume
> sequence.
> - pci-j721e: drop dead code.
> - Link to v1:
> https://lore.kernel.org/r/20240102-j7200-pcie-s2r-v1-0-84e55da52400@bootlin.com
>
> ---
> Thomas Richard (15):
> gpio: pca953x: move suspend()/resume() to
> suspend_noirq()/resume_noirq()
> pinctrl: pinctrl-single: remove dead code in suspend() and
> resume() callbacks
> pinctrl: pinctrl-single: move suspend()/resume() callbacks to
> noirq
> i2c: omap: wakeup the controller during suspend() callback
> mux: add mux_chip_resume() function
> phy: ti: phy-j721e-wiz: use dev_err_probe() instead of
> dev_err()
> phy: ti: phy-j721e-wiz: split wiz_clock_init() function
> phy: ti: phy-j721e-wiz: add resume support
> phy: cadence-torrent: extract calls to clk_get from
> cdns_torrent_clk
> phy: cadence-torrent: register resets even if the phy is
> already configured
> phy: cadence-torrent: add already_configured to struct
> cdns_torrent_phy
> phy: cadence-torrent: remove noop_ops phy operations
> phy: cadence-torrent: add suspend and resume support
> PCI: cadence: extract link setup sequence from
> cdns_pcie_host_setup()
> PCI: cadence: set cdns_pcie_host_init() global
>
> Théo Lebrun (3):
> mux: mmio: add resume support
> PCI: j721e: add reset GPIO to struct j721e_pcie
> PCI: j721e: add suspend and resume support
For the PCI patches Bjorn is most likely going to ask you to adjust
them to PCI's common commit style; see here [1]
In particular, PCI (afaik) has no convention for naming subcomponents
such as j721e and the info following the : is written beginning with an
upper case, e.g.
PCI: Add suspend and resume support for j721e
Regards,
P.
[1] https://lore.kernel.org/linux-pci/20171026223701.GA25649@bhelgaas-glaptop.roam.corp.google.com/
>
> drivers/gpio/gpio-pca953x.c | 7 +-
> drivers/i2c/busses/i2c-omap.c | 22 ++++
> drivers/mux/core.c | 30 +++++
> drivers/mux/mmio.c | 12 ++
> drivers/pci/controller/cadence/pci-j721e.c | 102
> ++++++++++++++++-
> drivers/pci/controller/cadence/pcie-cadence-host.c | 44 +++++---
> drivers/pci/controller/cadence/pcie-cadence.h | 12 ++
> drivers/phy/cadence/phy-cadence-torrent.c | 121
> +++++++++++++++------
> drivers/phy/ti/phy-j721e-wiz.c | 119
> +++++++++++++-------
> drivers/pinctrl/pinctrl-single.c | 28 ++---
> include/linux/mux/driver.h | 1 +
> 11 files changed, 380 insertions(+), 118 deletions(-)
> ---
> base-commit: 00ff0f9ce40db8e64fe16c424a965fd7ab769c42
> change-id: 20240102-j7200-pcie-s2r-ecb1a979e357
>
> Best regards,
next prev parent reply other threads:[~2024-02-15 15:40 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 15:17 [PATCH v3 00/18] Add suspend to ram support for PCIe on J7200 Thomas Richard
2024-02-15 15:17 ` [PATCH v3 01/18] gpio: pca953x: move suspend()/resume() to suspend_noirq()/resume_noirq() Thomas Richard
2024-02-21 21:54 ` Linus Walleij
2024-02-15 15:17 ` [PATCH v3 02/18] pinctrl: pinctrl-single: remove dead code in suspend() and resume() callbacks Thomas Richard
2024-02-15 15:27 ` Andy Shevchenko
2024-02-16 7:59 ` Thomas Richard
2024-02-16 15:08 ` Andy Shevchenko
2024-02-21 11:01 ` Thomas Richard
2024-02-21 13:13 ` Andy Shevchenko
2024-02-21 14:19 ` Thomas Richard
2024-02-15 15:17 ` [PATCH v3 03/18] pinctrl: pinctrl-single: move suspend()/resume() callbacks to noirq Thomas Richard
2024-02-15 15:17 ` [PATCH v3 04/18] i2c: omap: wakeup the controller during suspend() callback Thomas Richard
2024-02-15 15:30 ` Andy Shevchenko
2024-02-15 15:17 ` [PATCH v3 05/18] mux: add mux_chip_resume() function Thomas Richard
2024-02-15 15:29 ` Andy Shevchenko
2024-02-16 7:52 ` Thomas Richard
2024-02-16 15:07 ` Andy Shevchenko
2024-02-21 10:59 ` Thomas Richard
2024-02-15 15:17 ` [PATCH v3 06/18] mux: mmio: add resume support Thomas Richard
2024-02-15 15:17 ` [PATCH v3 07/18] phy: ti: phy-j721e-wiz: use dev_err_probe() instead of dev_err() Thomas Richard
2024-02-15 15:33 ` Andy Shevchenko
2024-02-15 15:17 ` [PATCH v3 08/18] phy: ti: phy-j721e-wiz: split wiz_clock_init() function Thomas Richard
2024-02-15 15:43 ` Andy Shevchenko
2024-02-16 6:02 ` Vinod Koul
2024-02-16 9:04 ` Siddharth Vadapalli
2024-02-16 15:03 ` Andy Shevchenko
2024-02-16 14:56 ` Andy Shevchenko
2024-02-15 15:17 ` [PATCH v3 09/18] phy: ti: phy-j721e-wiz: add resume support Thomas Richard
2024-02-15 15:17 ` [PATCH v3 10/18] phy: cadence-torrent: extract calls to clk_get from cdns_torrent_clk Thomas Richard
2024-02-15 15:17 ` [PATCH v3 11/18] phy: cadence-torrent: register resets even if the phy is already configured Thomas Richard
2024-02-15 15:17 ` [PATCH v3 12/18] phy: cadence-torrent: add already_configured to struct cdns_torrent_phy Thomas Richard
2024-02-15 15:17 ` [PATCH v3 13/18] phy: cadence-torrent: remove noop_ops phy operations Thomas Richard
2024-02-15 15:45 ` Andy Shevchenko
2024-02-15 15:17 ` [PATCH v3 14/18] phy: cadence-torrent: add suspend and resume support Thomas Richard
2024-02-15 15:46 ` Andy Shevchenko
2024-02-16 7:36 ` Thomas Richard
2024-02-21 13:09 ` Philipp Zabel
2024-02-21 13:41 ` Thomas Richard
2024-02-21 13:58 ` Philipp Zabel
2024-02-15 15:18 ` [PATCH v3 15/18] PCI: cadence: extract link setup sequence from cdns_pcie_host_setup() Thomas Richard
2024-02-16 9:34 ` Siddharth Vadapalli
2024-02-15 15:18 ` [PATCH v3 16/18] PCI: cadence: set cdns_pcie_host_init() global Thomas Richard
2024-02-16 9:38 ` Siddharth Vadapalli
2024-02-15 15:18 ` [PATCH v3 17/18] PCI: j721e: add reset GPIO to struct j721e_pcie Thomas Richard
2024-02-15 16:04 ` Andy Shevchenko
2024-02-26 17:05 ` Thomas Richard
2024-02-26 17:54 ` Andy Shevchenko
2024-02-15 15:18 ` [PATCH v3 18/18] PCI: j721e: add suspend and resume support Thomas Richard
2024-02-15 15:51 ` Andy Shevchenko
2024-02-16 10:48 ` Siddharth Vadapalli
2024-02-16 11:09 ` Théo Lebrun
2024-02-16 11:16 ` Siddharth Vadapalli
2024-02-15 15:40 ` Philipp Stanner [this message]
2024-02-15 17:06 ` [PATCH v3 00/18] Add suspend to ram support for PCIe on J7200 Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b2ffe636a19faef87b9c48fee6d17bfb9f1a3bf.camel@redhat.com \
--to=pstanner@redhat.com \
--cc=aaro.koskinen@iki.fi \
--cc=andi.shyti@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=bhelgaas@google.com \
--cc=brgl@bgdev.pl \
--cc=gregory.clement@bootlin.com \
--cc=haojian.zhuang@linaro.org \
--cc=jmkrzyszt@gmail.com \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=peda@axentia.se \
--cc=robh@kernel.org \
--cc=theo.lebrun@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=thomas.richard@bootlin.com \
--cc=tony@atomide.com \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).