From: Steven Rostedt <rostedt@goodmis.org>
To: Andy Shevchenko <andy@kernel.org>
Cc: "Hans de Goede" <hdegoede@redhat.com>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Joe Perches" <joe@perches.com>,
"Andreas Schwab" <schwab@linux-m68k.org>,
"Pali Rohár" <pali@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Paul Menzel" <pmenzel@molgen.mpg.de>,
"Jean Delvare" <jdelvare@suse.com>,
"Andi Shyti" <andi.shyti@kernel.org>,
eric.piel@tremplin-utc.net, "Marius Hoch" <mail@mariushoch.de>,
Dell.Client.Kernel@dell.com,
"Kai Heng Feng" <kai.heng.feng@canonical.com>,
platform-driver-x86@vger.kernel.org,
"Wolfram Sang" <wsa@kernel.org>,
linux-i2c@vger.kernel.org, "Tom Zanussi" <zanussi@kernel.org>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>
Subject: Re: [PATCH v2 2/6] platform/x86: dell-smo8800: Move instantiation of lis3lv02d i2c_client from i2c-i801 to dell-smo8800
Date: Sun, 7 Jan 2024 11:20:44 -0500 [thread overview]
Message-ID: <20240107112044.6702cb66@gandalf.local.home> (raw)
In-Reply-To: <20240107110917.3d6075de@gandalf.local.home>
On Sun, 7 Jan 2024 11:09:17 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> for (i = 0; i < hist_data->attrs->n_actions; i++) {
> str = hist_data->attrs->action_str[i];
>
> if ((len = str_has_prefix(str, "onmatch("))) {
> char *action_str = str + len;
>
> data = onmatch_parse(tr, action_str);
> if (IS_ERR(data)) {
> ret = PTR_ERR(data);
> break;
> }
> } else if ((len = str_has_prefix(str, "onmax("))) {
> char *action_str = str + len;
>
> data = track_data_parse(hist_data, action_str,
> HANDLER_ONMAX);
> if (IS_ERR(data)) {
> ret = PTR_ERR(data);
> break;
> }
> } else if ((len = str_has_prefix(str, "onchange("))) {
> char *action_str = str + len;
>
> data = track_data_parse(hist_data, action_str,
> HANDLER_ONCHANGE);
> if (IS_ERR(data)) {
> ret = PTR_ERR(data);
> break;
> }
And this could possibly be consolidated to:
for (i = 0; i < hist_data->attrs->n_actions; i++) {
char *action_str;
enum handler_id hid;
ret = -EINVAL;
str = hist_data->attrs->action_str[i];
if ((len = str_has_prefix(str, "onmatch(")))
hid = HANDLER_ONMATCH;
else if ((len = str_has_prefix(str, "onmax(")))
hid = HANDLER_ONMAX;
else if ((len = str_has_prefix(str, "onchange(")))
hid = HANDLER_ONCHANGE;
else
break;
action_str = str + len;
switch (hid) {
case HANDLER_ONMATCH:
data = onmatch_parse(tr, action_str);
break;
default:
data = track_data_parse(hist_data, action_str, hid);
}
if (IS_ERR(data)) {
ret = PTR_ERR(data);
break;
}
hist_data->actions[hist_data->n_actions++] = data;
ret = 0;
}
I think I'll go make that change!
-- Steve
next prev parent reply other threads:[~2024-01-07 16:19 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-06 16:09 [PATCH v2 0/6] i2c-i801 / dell-smo8800: Move instantiation of lis3lv02d i2c_client from i2c-i801 to dell-smo8800 Hans de Goede
2024-01-06 16:09 ` [PATCH v2 1/6] platform/x86: dell-smo8800: Change probe() ordering a bit Hans de Goede
2024-01-06 16:09 ` [PATCH v2 2/6] platform/x86: dell-smo8800: Move instantiation of lis3lv02d i2c_client from i2c-i801 to dell-smo8800 Hans de Goede
2024-01-06 16:24 ` Andy Shevchenko
2024-01-06 19:54 ` Joe Perches
2024-01-07 16:09 ` Steven Rostedt
2024-01-07 16:20 ` Steven Rostedt [this message]
2024-01-06 16:38 ` Pali Rohár
2024-01-07 17:10 ` Pali Rohár
2024-02-13 16:30 ` Jean Delvare
2024-02-17 10:33 ` Hans de Goede
2024-02-19 11:52 ` Andy Shevchenko
2024-02-27 21:04 ` Pali Rohár
2024-02-27 21:19 ` Andy Shevchenko
2024-02-27 21:50 ` Pali Rohár
2024-02-27 22:37 ` Andy Shevchenko
2024-02-28 12:50 ` Hans de Goede
2024-02-29 20:46 ` Pali Rohár
2024-03-02 11:02 ` Hans de Goede
2024-03-02 11:19 ` Pali Rohár
2024-02-27 21:40 ` Pali Rohár
2024-02-28 13:10 ` Hans de Goede
2024-02-28 16:49 ` Andy Shevchenko
2024-02-29 20:57 ` Pali Rohár
2024-03-02 11:38 ` Hans de Goede
2024-03-03 11:14 ` Andy Shevchenko
2024-01-13 4:42 ` kernel test robot
2024-01-13 7:46 ` kernel test robot
2024-01-06 16:09 ` [PATCH v2 3/6] platform/x86: dell-smo8800: Pass the IRQ to the lis3lv02d i2c_client Hans de Goede
2024-01-06 16:09 ` [PATCH v2 4/6] platform/x86: dell-smo8800: Allow using the IIO st_accel driver Hans de Goede
2024-01-13 9:55 ` kernel test robot
2024-01-13 14:24 ` kernel test robot
2024-01-06 16:09 ` [PATCH v2 5/6] platform/x86: dell-smo8800: Add support for probing for the accelerometer i2c address Hans de Goede
2024-01-06 16:09 ` [PATCH v2 6/6] platform/x86: dell-smo8800: Add a couple more models to dell_lis3lv02d_devices[] Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240107112044.6702cb66@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=Dell.Client.Kernel@dell.com \
--cc=andi.shyti@kernel.org \
--cc=andy@kernel.org \
--cc=eric.piel@tremplin-utc.net \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=joe@perches.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mail@mariushoch.de \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=pali@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
--cc=schwab@linux-m68k.org \
--cc=torvalds@linux-foundation.org \
--cc=wsa@kernel.org \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).