From: "Patrick Höhn" <hoehnp@gmx.de>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: "Jean Delvare" <jdelvare@suse.com>,
"Pali Rohár" <pali@kernel.org>,
"Paul Menzel" <pmenzel@molgen.mpg.de>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] i2c: i801: Add lis3lv02d for Dell Precision M6800 v2 Bios: A26
Date: Wed, 28 Feb 2024 23:54:10 +0100 [thread overview]
Message-ID: <25bdda18-4e05-42a6-a0e1-3e35a81ca90f@gmx.de> (raw)
In-Reply-To: <3s546clapu73llqqyhj7fhab5cwhchygrtq53juqcqoyttk2dx@47ylvwpqso5d>
Hi Andi,
sorry for the late response. Since it is the first time I am
contributing, please excuse me, if my description still needs
improvement. I can simply describe what I did:
similiarly to what Paul did before, I identified that the M6800 has the
accelerometer installed and verified its address using my running Gentoo
System. Then I was applying the patch to latest kernel and confirmed
that it was booting successfully and the message about a successful
detection was present.
Is this along the lines you expect?
Best Regards,
Patrick
Den 2024-02-22 kl. 23:24, skrev Andi Shyti:
> Hi Patrick,
>
> On Thu, Feb 22, 2024 at 10:50:08PM +0100, Patrick Höhn wrote:
>> Signed-off-by: Patrick Höhn <hoehnp@gmx.de>
>
> I see that you've fixed almost everything that Paul has
> suggested, but please elaborate a bit more in the git commit.
>
> Spend some time adding a description. If you want, you can reply
> to this email with the commit log you have in mind, and I can add
> it for you, or you can send a v3.
>
> Thank you, Paul, for your excellent review.
>
> Andi
>
> PS: A small nitpick: there's no need to add 'v2' in the title.
> '[PATCH v2]' is sufficient.
>
>> ---
>> drivers/i2c/busses/i2c-i801.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
>> index 2c36b36d7d51..c1fee2c61da1 100644
>> --- a/drivers/i2c/busses/i2c-i801.c
>> +++ b/drivers/i2c/busses/i2c-i801.c
>> @@ -1231,6 +1231,7 @@ static const struct {
>> */
>> { "Latitude 5480", 0x29 },
>> { "Precision 3540", 0x29 },
>> + { "Precision M6800", 0x29 },
>> { "Vostro V131", 0x1d },
>> { "Vostro 5568", 0x29 },
>> { "XPS 15 7590", 0x29 },
>> --
>> 2.43.0
>>
prev parent reply other threads:[~2024-02-28 22:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 21:50 [PATCH v2] i2c: i801: Add lis3lv02d for Dell Precision M6800 v2 Bios: A26 Patrick Höhn
2024-02-22 22:24 ` Andi Shyti
2024-02-28 22:54 ` Patrick Höhn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25bdda18-4e05-42a6-a0e1-3e35a81ca90f@gmx.de \
--to=hoehnp@gmx.de \
--cc=andi.shyti@kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pali@kernel.org \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).